Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: fix(common): format day-periods that cross midnight (#36611) #36751

Closed
wants to merge 1 commit into from
Closed

revert: fix(common): format day-periods that cross midnight (#36611) #36751

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Apr 22, 2020 •
edited

This reverts commit 1756cce.

The reason for this revert is because of the change being too risky for
a patch release of Angular. Changing date formatting proves to be a
breaking change and can only be apart of the next release.

@pullapprove pullapprove bot requested a review from mhevery April 22, 2020 02:21
kara
kara requested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the reason why this commit is being reverted to the commit message?

@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 22, 2020
@matsko
revert: fix(common): format day-periods that cross midnight (angular#…
039f37d 
…36611)

This reverts commit 1756cce.

The reason for this revert is because of the change being too risky for
a patch release of Angular. Changing date formatting proves to be a
breaking change and can only be apart of the next release.
kara
kara approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matsko matsko added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 22, 2020
matsko added a commit that referenced this pull request Apr 22, 2020
@matsko
revert: fix(common): format day-periods that cross midnight (#36611) (#…
8bd5374 
…36751)

This reverts commit 1756cce.

The reason for this revert is because of the change being too risky for
a patch release of Angular. Changing date formatting proves to be a
breaking change and can only be apart of the next release.

PR Close #36751
@matsko matsko closed this Apr 22, 2020
@IgorMinar IgorMinar mentioned this pull request May 16, 2020
Closed
3 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@mhevery mhevery Awaiting requested review from mhevery

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matsko @kara @googlebot