Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): add name spans for property reads and method calls #36826

Closed
wants to merge 5 commits into from
Closed

feat(compiler): add name spans for property reads and method calls #36826

wants to merge 5 commits into from

Commits on May 5, 2020

  1. feat(compiler): add name spans for property reads and method calls 

    ASTs for property read and method calls contain information about
the entire span of the expression, including its receiver. Use cases
like a language service and compile error messages may be more
interested in the span of the direct identifier for which the
expression is constructed (i.e. an accessed property). To support this,
this commit adds a `nameSpan` property on

- `PropertyRead`s
- `SafePropertyRead`s
- `PropertyWrite`s
- `MethodCall`s
- `SafeMethodCall`s

The `nameSpan` property already existed for `BindingPipe`s.

This commit also updates usages of these expressions' `sourceSpan`s in
Ngtsc and the langauge service to use `nameSpan`s where appropriate.
    @ayazhafiz
    ayazhafiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e7a6f67 View commit details
    Browse the repository at this point in the history

  2. fixup! feat(compiler): add name spans for property reads and method c… 

    …alls
    @ayazhafiz
    ayazhafiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    2c6eae6 View commit details
    Browse the repository at this point in the history

  3. fixup! feat(compiler): add name spans for property reads and method c… 

    …alls
    @ayazhafiz
    ayazhafiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    80e887d View commit details
    Browse the repository at this point in the history

  4. fixup! feat(compiler): add name spans for property reads and method c… 

    …alls
    @ayazhafiz
    ayazhafiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c815151 View commit details
    Browse the repository at this point in the history

  5. fixup! feat(compiler): add name spans for property reads and method c… 

    …alls
    @ayazhafiz
    ayazhafiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b463116 View commit details
    Browse the repository at this point in the history