Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixes ngOnit routing code #36905

Closed
wants to merge 1 commit into from
Closed

docs: fixes ngOnit routing code #36905

wants to merge 1 commit into from

Conversation

sonukapoor
Copy link
Contributor

@sonukapoor sonukapoor commented May 4, 2020 •
edited

Closes #36885

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #36885

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott May 4, 2020 01:18
@sonukapoor
docs: fixes ngOnit routing variable
ce8595e 
This commit fixes the routing variable in the `ngOnit` life-cyle event from
`activatedRoute` to `route`.

Closes angular#36885
@ngbot ngbot bot added this to the needsTriage milestone May 4, 2020
@atscott atscott added the target: patch This PR is targeted for the next patch release label May 4, 2020
kapunahelewong
kapunahelewong approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, @sonukapoor!!

@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 7, 2020
@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label May 7, 2020
atscott
atscott approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed for: fw-router

mhevery pushed a commit that referenced this pull request May 12, 2020
@sonukapoor @mhevery
docs: fixes ngOnit routing variable (#36905)
77218d6 
This commit fixes the routing variable in the `ngOnit` life-cyle event from
`activatedRoute` to `route`.

Closes #36885

PR Close #36905
@mhevery mhevery closed this in 2cddeab May 12, 2020
@sonukapoor sonukapoor deleted the outdated-route-code branch May 12, 2020 21:48
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 12, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@sonukapoor @profanis
docs: fixes ngOnit routing variable (angular#36905)
eac219a 
This commit fixes the routing variable in the `ngOnit` life-cyle event from
`activatedRoute` to `route`.

Closes angular#36885

PR Close angular#36905
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@kapunahelewong kapunahelewong kapunahelewong approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

outdated code in angular routing documentation
4 participants
@sonukapoor @atscott @kapunahelewong @googlebot