Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs-infra): refactors addImageDimensionsImpl #37046

Closed

Conversation

sonukapoor
Copy link
Contributor

Change addImageDimensionsImpl to reduce nesting.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - unfortunately you need to make the body of the commit message longer (>100 chars) to pass the lint check.

@petebacondarwin petebacondarwin added comp: docs-infra action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker refactoring Issue that involves refactoring or code-cleanup labels May 11, 2020
@ngbot ngbot bot added this to the needsTriage milestone May 11, 2020
@ngbot
Copy link

ngbot bot commented May 11, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    pending missing required labels: PR target: *
    pending forbidden labels detected: PR action: cleanup
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@petebacondarwin petebacondarwin removed the request for review from IgorMinar May 11, 2020 13:57
@petebacondarwin petebacondarwin added the target: patch This PR is targeted for the next patch release label May 11, 2020
@sonukapoor
Copy link
Contributor Author

LGTM - unfortunately you need to make the body of the commit message longer (>100 chars) to pass the lint check.

I saw this new requirement, but at the same time, I can see PRs that are merged without fulfilling them - Is that normal?

This one for example 77d8afb

@petebacondarwin
Copy link
Member

That looks like a special commit created by the release script. So I don't know if it had to go through the same checks.

@sonukapoor
Copy link
Contributor Author

That looks like a special commit created by the release script. So I don't know if it had to go through the same checks.

Yes, I will try to add some other info to the body

This commit changes the `addImageDimensionsImpl` method to reduce
nesting. It will exit early, if the conditions are not matched.
@sonukapoor sonukapoor force-pushed the refactor-add-image-dimensions branch from c0e8ebd to c325d1f Compare May 11, 2020 16:36
@petebacondarwin petebacondarwin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 14, 2020
@kara kara closed this in 2418c6a May 14, 2020
kara pushed a commit that referenced this pull request May 14, 2020
This commit changes the `addImageDimensionsImpl` method to reduce
nesting. It will exit early, if the conditions are not matched.

PR Close #37046
@sonukapoor sonukapoor deleted the refactor-add-image-dimensions branch May 14, 2020 18:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 14, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
This commit changes the `addImageDimensionsImpl` method to reduce
nesting. It will exit early, if the conditions are not matched.

PR Close angular#37046
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants