-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(docs-infra): refactors addImageDimensionsImpl
#37046
refactor(docs-infra): refactors addImageDimensionsImpl
#37046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - unfortunately you need to make the body of the commit message longer (>100 chars) to pass the lint check.
I saw this new requirement, but at the same time, I can see PRs that are merged without fulfilling them - Is that normal? This one for example 77d8afb |
That looks like a special commit created by the release script. So I don't know if it had to go through the same checks. |
Yes, I will try to add some other info to the |
This commit changes the `addImageDimensionsImpl` method to reduce nesting. It will exit early, if the conditions are not matched.
c0e8ebd
to
c325d1f
Compare
This commit changes the `addImageDimensionsImpl` method to reduce nesting. It will exit early, if the conditions are not matched. PR Close #37046
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit changes the `addImageDimensionsImpl` method to reduce nesting. It will exit early, if the conditions are not matched. PR Close angular#37046
Change
addImageDimensionsImpl
to reduce nesting.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?