Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in committer.md #37171

Closed

Conversation

JiaLiPassion
Copy link
Contributor

Fix a type of COMMITTER.md, the url of the pullapprove service should be https://docs.pullapprove.com/,
now the document has an additional https prefix.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Fix a type of COMMITTER.md, the url of the pullapprove service should be https://docs.pullapprove.com/,
now the document has an additional `https` prefix.
@pullapprove pullapprove bot requested a review from gkalpak May 18, 2020 05:03
@JiaLiPassion JiaLiPassion added target: patch This PR is targeted for the next patch release risk: low labels May 18, 2020
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @JiaLiPassion!!

Reviewed-for: global-docs-approvers

@gkalpak gkalpak removed their request for review May 21, 2020 16:13
@pullapprove pullapprove bot requested a review from gkalpak May 21, 2020 16:14
@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label May 21, 2020
@ngbot ngbot bot added this to the Backlog milestone May 21, 2020
@matsko matsko closed this in df08230 May 28, 2020
matsko pushed a commit that referenced this pull request May 28, 2020
Fix a type of COMMITTER.md, the url of the pullapprove service should be https://docs.pullapprove.com/,
now the document has an additional `https` prefix.

PR Close #37171
ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
Fix a type of COMMITTER.md, the url of the pullapprove service should be https://docs.pullapprove.com/,
now the document has an additional `https` prefix.

PR Close angular#37171
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 29, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
Fix a type of COMMITTER.md, the url of the pullapprove service should be https://docs.pullapprove.com/,
now the document has an additional `https` prefix.

PR Close angular#37171
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants