-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update components repo unit tests job commit #37176
ci: update components repo unit tests job commit #37176
Conversation
devversion
commented
May 18, 2020
•
edited
edited
- See individual commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: doesn't apply cleanly to patch. @devversion Can you create another PR for that? |
Updates the commit the `components-repo-unit-tests` job runs against. The goal is that we run against a revision that at least contains: angular/components#19336. The new commit contains fixes for a flaky test in the datepicker that we saw failing in the components-repo-unit-tests job too: https://app.circleci.com/pipelines/github/angular/angular/15359/workflows/27ffae7c-a7b8-46a3-9c9e-6dd22ca4734d/jobs/712643. Additionally, with this commit, the components repo unit tests job will use TypeScript 3.9.2, so we can re-enable the job in another commit.
With 844208f, we disabled the components-repo-unit-tests job. The components repo landed the required TS 3.9.x update, so we can re-enable the job again.
45aa494
to
c1c2034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wanted to send another PR for updating to the components-repo commit for the TS 3.9 update, but changes were so similar, I incorporated that into this PR. Also this now re-enables the job. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates the commit the `components-repo-unit-tests` job runs against. The goal is that we run against a revision that at least contains: angular/components#19336. The new commit contains fixes for a flaky test in the datepicker that we saw failing in the components-repo-unit-tests job too: https://app.circleci.com/pipelines/github/angular/angular/15359/workflows/27ffae7c-a7b8-46a3-9c9e-6dd22ca4734d/jobs/712643. Additionally, with this commit, the components repo unit tests job will use TypeScript 3.9.2, so we can re-enable the job in another commit. PR Close angular#37176
With 844208f, we disabled the components-repo-unit-tests job. The components repo landed the required TS 3.9.x update, so we can re-enable the job again. PR Close angular#37176