docs: describe how to configure CommonJS modules #37331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview d480de2 at https://pr37331-d480de2.ngbuilds.io/. |
alan-agius4
reviewed
Jun 1, 2020
alan-agius4
reviewed
Jun 1, 2020
alan-agius4
reviewed
Jun 1, 2020
aikithoughts
commented
Jun 1, 2020
|
You can preview aa6f505 at https://pr37331-aa6f505.ngbuilds.io/. |
|
You can preview 9a8e59c at https://pr37331-9a8e59c.ngbuilds.io/. |
alan-agius4
reviewed
Jun 5, 2020
alan-agius4
reviewed
Jun 5, 2020
aikithoughts
commented
Jun 8, 2020
alan-agius4
added
the
target: patch
alan-agius4
approved these changes
Jun 9, 2020
alan-agius4
added
the
action: cleanup
aikithoughts
added
effort2: days
risk: low
and removed
action: cleanup
|
You can preview d6e7954 at https://pr37331-d6e7954.ngbuilds.io/. |
IgorMinar
approved these changes
Jun 10, 2020
IgorMinar
added
the
action: cleanup
There was a problem hiding this comment.
you can checkout https://angular.io/guide/docs-style-guide#markdown-and-html if you have any doubts
|
You can preview 12db3ac at https://pr37331-12db3ac.ngbuilds.io/. |
aikithoughts
removed
the
action: cleanup
In version 10, we have a new option for the `angular.json` file, `allowedCommonJsDependencies`, so users can opt in to support CommonJS modules.
mhevery
pushed a commit
that referenced
this pull request
Jun 15, 2020
In version 10, we have a new option for the `angular.json` file, `allowedCommonJsDependencies`, so users can opt in to support CommonJS modules. PR Close #37331
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
In version 10, we have a new option for the `angular.json` file, `allowedCommonJsDependencies`, so users can opt in to support CommonJS modules. PR Close angular#37331
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
In version 10, we have a new option for the `angular.json` file, `allowedCommonJsDependencies`, so users can opt in to support CommonJS modules. PR Close angular#37331
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 10, we have a new option for the
angular.jsonfile,allowedCommonJsDependencies, so users can opt in to supportCommonJS modules.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current documentation does not describe how to configure the
angular.jsonfile to support CommonJS modules.Issue Number: N/A
What is the new behavior?
Add section that describes how to configure the
angular.jsonfile to support CommonJS modules.Does this PR introduce a breaking change?
Other information