Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): avoid abort a request when fetch operation is completed #37367

Closed
wants to merge 1 commit into from
Closed

fix(http): avoid abort a request when fetch operation is completed #37367

wants to merge 1 commit into from

Conversation

dimakuba
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

abort method is calling, even if fetch operation is completed.

Issue Number: #36537

What is the new behavior?

Avoid abort a request when fetch operation is completed.

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested review from atscott and IgorMinar May 31, 2020 14:44
@dimakuba @dmkuba
fix(http): avoid abort a request when fetch operation is completed
ad387f5 
`abort` method is calling, even if fetch operation is completed

Fixes angular#36537
@ngbot ngbot bot added this to the needsTriage milestone Jun 3, 2020
@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Jun 15, 2020
@alxhub alxhub added the target: patch This PR is targeted for the next patch release label Jun 15, 2020
@alxhub
Copy link
Member

alxhub commented Jun 15, 2020

Presubmit

@AndrewKushnir
Copy link
Contributor

Presubmit #2

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: presubmit The PR is in need of a google3 presubmit labels Jun 24, 2020
AndrewKushnir pushed a commit that referenced this pull request Jun 25, 2020
@dimakuba @AndrewKushnir
fix(http): avoid abort a request when fetch operation is completed (#…
a5d5f67 
…37367)

`abort` method is calling, even if fetch operation is completed

Fixes #36537

PR Close #37367
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 26, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@dimakuba @profanis
fix(http): avoid abort a request when fetch operation is completed (a…
9a59992 
…ngular#37367)

`abort` method is calling, even if fetch operation is completed

Fixes angular#36537

PR Close angular#37367
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common/http cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dimakuba @alxhub @AndrewKushnir @matsko @googlebot