-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(language-service): Improve signature selection by finding exact match #37494
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
…atch The function signature selection algorithm is totally naive. It'd unconditionally pick the first signature if there are multiple overloads. This commit improves the algorithm by returning an exact match if one exists.
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
…atch (angular#37494) The function signature selection algorithm is totally naive. It'd unconditionally pick the first signature if there are multiple overloads. This commit improves the algorithm by returning an exact match if one exists. PR Close angular#37494
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…atch (angular#37494) The function signature selection algorithm is totally naive. It'd unconditionally pick the first signature if there are multiple overloads. This commit improves the algorithm by returning an exact match if one exists. PR Close angular#37494
The function signature selection algorithm is totally naive. It'd
unconditionally pick the first signature if there are multiple
overloads. This commit improves the algorithm by returning an exact
match if one exists.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information