Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix contributor website links with no protocol #37528

Closed

Conversation

kgajera
Copy link
Contributor

@kgajera kgajera commented Jun 10, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

There are a couple contributor website links that do not have a protocol which is causing the links to not work.

What is the new behavior?

Simply adds "http" protocol so the links work.

@pullapprove pullapprove bot requested a review from IgorMinar June 10, 2020 19:52
@ngbot ngbot bot added this to the needsTriage milestone Jun 10, 2020
Two contributor website links do not have a protocol so they are treated as a relative URL and do not work as expected.
@kgajera kgajera force-pushed the fix-contributor-website-links branch from 459b5af to 9bba5d0 Compare June 10, 2020 20:20
@IgorMinar
Copy link
Contributor

thank you @kgajera !

@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jun 12, 2020
@mhevery mhevery closed this in 7cc7955 Jun 12, 2020
mhevery pushed a commit that referenced this pull request Jun 12, 2020
Two contributor website links do not have a protocol so they are treated as a relative URL and do not work as expected.

PR Close #37528
@kgajera kgajera deleted the fix-contributor-website-links branch June 12, 2020 20:08
ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
Two contributor website links do not have a protocol so they are treated as a relative URL and do not work as expected.

PR Close angular#37528
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 13, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
Two contributor website links do not have a protocol so they are treated as a relative URL and do not work as expected.

PR Close angular#37528
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants