Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(benchpress): bump version to v0.2.1 and update @angular/core peer dependency #37676

Conversation

devversion
Copy link
Member

Updates the version of @angular/benchpress to the next patch
version. i.e. v0.2.1. Additionally, the peer dependency
on @angular/core has been updated to be satisifed with
Angular v10 and v11.

Benchpress should be at least compatibe with the next two major
versions as it does not rely on any deprecated API from @angular/core.

Note: You might be wondering why this PR proposes the version bump. This is because
benchpress is not released as part of other framework packages, and after this PR being
merged, we should cut a manual release of benchpress with the new version.

@devversion devversion force-pushed the refactor/benchpress-peer-dependency branch from f52d9e4 to 245d60d Compare June 22, 2020 18:10
@devversion devversion added area: benchpress area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Jun 22, 2020
@ngbot ngbot bot modified the milestone: needsTriage Jun 22, 2020
@devversion devversion marked this pull request as ready for review June 22, 2020 18:10
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Removes unused packages from the benchpress `package.json`. That
helps with deduping dependencies, and avoiding unused code
being downloaded.
…` peer dependency

Updates the version of `@angular/benchpress` to the next patch
version. i.e. `v0.2.1`. Additionally, the peer dependency
on `@angular/core` has been updated to be satisifed with
Angular v10 and v11.

Benchpress should be at least compatibe with the next two major
versions as it does not rely on any deprecated API from `@angular/core`.
@devversion devversion force-pushed the refactor/benchpress-peer-dependency branch from 245d60d to 7158028 Compare June 22, 2020 18:22
@devversion
Copy link
Member Author

@josephperrott Pushed another commit for cleaning up unused dependencies. Please have another look when you get a chance. Thanks!

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, always happy to see removal of unused dependencies.

@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 22, 2020
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 22, 2020
AndrewKushnir pushed a commit that referenced this pull request Jun 25, 2020
…` peer dependency (#37676)

Updates the version of `@angular/benchpress` to the next patch
version. i.e. `v0.2.1`. Additionally, the peer dependency
on `@angular/core` has been updated to be satisifed with
Angular v10 and v11.

Benchpress should be at least compatibe with the next two major
versions as it does not rely on any deprecated API from `@angular/core`.

PR Close #37676
@AndrewKushnir
Copy link
Contributor

@devversion @josephperrott, FYI this PR is now merged. Please proceed with the next steps as needed ("benchpress" release?). Thank you.

@josephperrott
Copy link
Member

@angular/benchpress@0.2.1 has been published.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 26, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
…37676)

Removes unused packages from the benchpress `package.json`. That
helps with deduping dependencies, and avoiding unused code
being downloaded.

PR Close angular#37676
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
…` peer dependency (angular#37676)

Updates the version of `@angular/benchpress` to the next patch
version. i.e. `v0.2.1`. Additionally, the peer dependency
on `@angular/core` has been updated to be satisifed with
Angular v10 and v11.

Benchpress should be at least compatibe with the next two major
versions as it does not rely on any deprecated API from `@angular/core`.

PR Close angular#37676
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: benchpress area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants