-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release(benchpress): bump version to v0.2.1 and update @angular/core
peer dependency
#37676
release(benchpress): bump version to v0.2.1 and update @angular/core
peer dependency
#37676
Conversation
f52d9e4
to
245d60d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes unused packages from the benchpress `package.json`. That helps with deduping dependencies, and avoiding unused code being downloaded.
…` peer dependency Updates the version of `@angular/benchpress` to the next patch version. i.e. `v0.2.1`. Additionally, the peer dependency on `@angular/core` has been updated to be satisifed with Angular v10 and v11. Benchpress should be at least compatibe with the next two major versions as it does not rely on any deprecated API from `@angular/core`.
245d60d
to
7158028
Compare
@josephperrott Pushed another commit for cleaning up unused dependencies. Please have another look when you get a chance. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM, always happy to see removal of unused dependencies.
…` peer dependency (#37676) Updates the version of `@angular/benchpress` to the next patch version. i.e. `v0.2.1`. Additionally, the peer dependency on `@angular/core` has been updated to be satisifed with Angular v10 and v11. Benchpress should be at least compatibe with the next two major versions as it does not rely on any deprecated API from `@angular/core`. PR Close #37676
@devversion @josephperrott, FYI this PR is now merged. Please proceed with the next steps as needed ("benchpress" release?). Thank you. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…37676) Removes unused packages from the benchpress `package.json`. That helps with deduping dependencies, and avoiding unused code being downloaded. PR Close angular#37676
…` peer dependency (angular#37676) Updates the version of `@angular/benchpress` to the next patch version. i.e. `v0.2.1`. Additionally, the peer dependency on `@angular/core` has been updated to be satisifed with Angular v10 and v11. Benchpress should be at least compatibe with the next two major versions as it does not rely on any deprecated API from `@angular/core`. PR Close angular#37676
Updates the version of
@angular/benchpress
to the next patchversion. i.e.
v0.2.1
. Additionally, the peer dependencyon
@angular/core
has been updated to be satisifed withAngular v10 and v11.
Benchpress should be at least compatibe with the next two major
versions as it does not rely on any deprecated API from
@angular/core
.Note: You might be wondering why this PR proposes the version bump. This is because
benchpress is not released as part of other framework packages, and after this PR being
merged, we should cut a manual release of benchpress with the new version.