-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add strict-mode.md file to pullapprove #37679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: code-ownership
c54c504
to
7a9be39
Compare
.pullapprove.yml
Outdated
@@ -958,6 +958,7 @@ groups: | |||
'aio/content/images/guide/deployment/**', | |||
'aio/content/guide/file-structure.md', | |||
'aio/content/guide/ivy.md', | |||
'aio/content/guide/strict-mode', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'aio/content/guide/strict-mode', | |
'aio/content/guide/strict-mode.md', |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
When I created the strict-mode.md file, I didn't add it to the pullapprove list. Now it's there. The issue was introduced in angular#37486.
c9b30bc
to
e233425
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
When I created the strict-mode.md file, I didn't add it to the pullapprove list. Now it's there. The issue was introduced in angular#37486. PR Close angular#37679
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When I created the strict-mode.md file, I didn't add it to the pullapprove list. Now it's there. The issue was introduced in angular#37486. PR Close angular#37679
When I created the strict-mode.md file, I didn't add it to the
pullapprove list. Now it's there.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Strict mode file not in pullapprove.yml
Issue Number: N/A
What is the new behavior?
Strict mode file is in pullapprove.yml
Does this PR introduce a breaking change?
Other information