docs-infra: update deploy-to-firebase.sh script to support v9 multisi… #37721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
force-pushed
the
aio/v9-deploy-to-firebase-update
branch
from
9fd9296
to
b0bbf00
Compare
IgorMinar
added
target: patch
|
Once this PR is approved, it will need to be cherry-picked into the v9 branch, otherwise it won't autodeploy the next time we push to it (which should be rare, but can still happen). |
…ultisite setup v9.angular.io was used to pilot the firebase hosting multisites setup for angular.io. The deployments so far have been done manually to control the deployment process. This change, automates the deployment for v9.angular.io so that future deployments can be made from the CI. See https://angular-team.atlassian.net/browse/DEV-125 for more info. In the process of updating the scripts I rediscovered a bug in the deploy-to-firebase.sh script that incorrect compared two numbers as strings. This previously worked correctly because we were comparing single digit numbers. With the release of v10, we now compare 9 > 10 which behaves differently for strings and numbers. The bug was fixed by switching to an arithmetic comparison of the two variables. This bug has been fixed on the master branch but not on the 9.1.x branch. I realized this during the rebase, but found my version to be a bit cleaner, so I kept it.
IgorMinar
force-pushed
the
aio/v9-deploy-to-firebase-update
branch
from
b0bbf00
to
c9b8aca
Compare
|
You can preview c9b8aca at https://pr37721-c9b8aca.ngbuilds.io/. |
gkalpak
added
action: cleanup
…rt v9 multisite setup
gkalpak
added
action: merge
|
You can preview 62e7fd9 at https://pr37721-62e7fd9.ngbuilds.io/. |
IgorMinar
commented
Jun 25, 2020
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "hosting": { | |||
| "public": "dist", | |||
There was a problem hiding this comment.
:) thank you @gkalpak!
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 25, 2020
…ultisite setup (#37721) v9.angular.io was used to pilot the firebase hosting multisites setup for angular.io. The deployments so far have been done manually to control the deployment process. This change, automates the deployment for v9.angular.io so that future deployments can be made from the CI. See https://angular-team.atlassian.net/browse/DEV-125 for more info. In the process of updating the scripts I rediscovered a bug in the deploy-to-firebase.sh script that incorrect compared two numbers as strings. This previously worked correctly because we were comparing single digit numbers. With the release of v10, we now compare 9 > 10 which behaves differently for strings and numbers. The bug was fixed by switching to an arithmetic comparison of the two variables. This bug has been fixed on the master branch but not on the 9.1.x branch. I realized this during the rebase, but found my version to be a bit cleaner, so I kept it. PR Close #37721
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
…ultisite setup (angular#37721) v9.angular.io was used to pilot the firebase hosting multisites setup for angular.io. The deployments so far have been done manually to control the deployment process. This change, automates the deployment for v9.angular.io so that future deployments can be made from the CI. See https://angular-team.atlassian.net/browse/DEV-125 for more info. In the process of updating the scripts I rediscovered a bug in the deploy-to-firebase.sh script that incorrect compared two numbers as strings. This previously worked correctly because we were comparing single digit numbers. With the release of v10, we now compare 9 > 10 which behaves differently for strings and numbers. The bug was fixed by switching to an arithmetic comparison of the two variables. This bug has been fixed on the master branch but not on the 9.1.x branch. I realized this during the rebase, but found my version to be a bit cleaner, so I kept it. PR Close angular#37721
IgorMinar
added a commit
to IgorMinar/angular
that referenced
this pull request
Jun 25, 2020
…nches The deployment to aio is currently failing because angular#37721 introduced "project" entry into the firebase.json which means that we now need to select the deployment target before deploying to firebase. This change fixes the issue and refactors the file to be easier to read. I also added extra echo statements so that the CI logs are easier to read in case we need to troubleshoot future issues.
IgorMinar
added a commit
to IgorMinar/angular
that referenced
this pull request
Jun 25, 2020
…nches The deployment to aio is currently failing because angular#37721 introduced "project" entry into the firebase.json which means that we now need to select the deployment target before deploying to firebase. This change fixes the issue and refactors the file to be easier to read. I also added extra echo statements so that the CI logs are easier to read in case we need to troubleshoot future issues.
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 26, 2020
…nches (#37762) The deployment to aio is currently failing because #37721 introduced "project" entry into the firebase.json which means that we now need to select the deployment target before deploying to firebase. This change fixes the issue and refactors the file to be easier to read. I also added extra echo statements so that the CI logs are easier to read in case we need to troubleshoot future issues. PR Close #37762
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 26, 2020
…nches (#37762) The deployment to aio is currently failing because #37721 introduced "project" entry into the firebase.json which means that we now need to select the deployment target before deploying to firebase. This change fixes the issue and refactors the file to be easier to read. I also added extra echo statements so that the CI logs are easier to read in case we need to troubleshoot future issues. PR Close #37762
IgorMinar
added a commit
to IgorMinar/angular
that referenced
this pull request
Jun 26, 2020
…nches (angular#37762) The deployment to aio is currently failing because angular#37721 introduced "project" entry into the firebase.json which means that we now need to select the deployment target before deploying to firebase. This change fixes the issue and refactors the file to be easier to read. I also added extra echo statements so that the CI logs are easier to read in case we need to troubleshoot future issues. PR Close angular#37762
IgorMinar
added a commit
to IgorMinar/angular
that referenced
this pull request
Jun 26, 2020
…nches (angular#37762) The deployment to aio is currently failing because angular#37721 introduced "project" entry into the firebase.json which means that we now need to select the deployment target before deploying to firebase. This change fixes the issue and refactors the file to be easier to read. I also added extra echo statements so that the CI logs are easier to read in case we need to troubleshoot future issues. PR Close angular#37762
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ultisite setup (angular#37721) v9.angular.io was used to pilot the firebase hosting multisites setup for angular.io. The deployments so far have been done manually to control the deployment process. This change, automates the deployment for v9.angular.io so that future deployments can be made from the CI. See https://angular-team.atlassian.net/browse/DEV-125 for more info. In the process of updating the scripts I rediscovered a bug in the deploy-to-firebase.sh script that incorrect compared two numbers as strings. This previously worked correctly because we were comparing single digit numbers. With the release of v10, we now compare 9 > 10 which behaves differently for strings and numbers. The bug was fixed by switching to an arithmetic comparison of the two variables. This bug has been fixed on the master branch but not on the 9.1.x branch. I realized this during the rebase, but found my version to be a bit cleaner, so I kept it. PR Close angular#37721
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te setup
v9.angular.io was used to pilot the firebase hosting multisites setup for angular.io.
The deployments so far have been done manually to control the deployment process.
This change, automates the deployment for v9.angular.io so that future deployments can be made from
the CI.
See https://angular-team.atlassian.net/browse/DEV-125 for more info.
In the process of updating the scripts I rediscovered a bug in the deploy-to-firebase.sh script that incorrect compared two numbers as strings. This previously worked correctly because we were comparing single digit numbers. With the release of v10, we now compare 9 > 10 which behaves differently for strings and numbers. The bug was fixed by switching to an arithmetic comparison of the two variables.
This bug has been fixed on the master branch but not on the 9.1.x branch. I realized this during the rebase, but found my version to be a bit cleaner, so I kept it.