Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove obsolete Bazel function ctx.new_file #38080

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jul 15, 2020

This is a resurrection of #37759
I made a mistake in git push and accidentally closed the PR.

The function was removed by default in Bazel 0.27.
It is still accessible with the flag --incompatible_new_actions_api
(which is set in Google code base), but the flag will be deleted very soon.

This change should be a no-op for Bazel users. The change was tested in
Google (cl/318277076) and should be safe as well.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The function was removed by default in Bazel 0.27.
It is still accessible with the flag `--incompatible_new_actions_api`
(which is set in Google code base), but the flag will be deleted very soon.

This change should be a no-op for Bazel users. The change was tested in
Google (cl/318277076) and should be safe as well.
@pullapprove pullapprove bot requested a review from IgorMinar July 15, 2020 17:20
@kyliau kyliau removed the request for review from IgorMinar July 15, 2020 17:23
@pullapprove pullapprove bot requested a review from IgorMinar July 15, 2020 17:23
@kyliau kyliau requested review from dgp1130 and devversion and removed request for IgorMinar July 15, 2020 17:23
@kyliau
Copy link
Contributor Author

kyliau commented Jul 15, 2020

@kyliau kyliau removed the request for review from devversion July 15, 2020 17:32
@pullapprove pullapprove bot requested a review from IgorMinar July 15, 2020 17:32
@kyliau kyliau requested review from devversion and removed request for IgorMinar July 15, 2020 17:40
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the same as the previous PR, you can probably just force successful presubmit and link to the old ID rather than running a new one.

@kyliau kyliau added the area: bazel Issues related to the published `@angular/bazel` build rules label Jul 15, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jul 15, 2020
@kyliau kyliau added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Jul 15, 2020
@kyliau
Copy link
Contributor Author

kyliau commented Jul 15, 2020

cc: @laurentlb this is good to go, thank you!

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Jul 16, 2020
…8080)"

This reverts commit 406f801.

The reason for the revert is the breakage in i18n subsystem in g3.
@AndrewKushnir
Copy link
Contributor

FYI, I had to rollback this change due to the issues in Google's codebase (see PR #38101), so I'me reopening this PR.

@AndrewKushnir AndrewKushnir reopened this Jul 16, 2020
@AndrewKushnir AndrewKushnir added state: blocked and removed action: merge The PR is ready for merge by the caretaker labels Jul 16, 2020
AndrewKushnir added a commit that referenced this pull request Jul 16, 2020
…38101)

This reverts commit 406f801.

The reason for the revert is the breakage in i18n subsystem in g3.

PR Close #38101
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
The function was removed by default in Bazel 0.27.
It is still accessible with the flag `--incompatible_new_actions_api`
(which is set in Google code base), but the flag will be deleted very soon.

This change should be a no-op for Bazel users. The change was tested in
Google (cl/318277076) and should be safe as well.

PR Close angular#38080
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
…8080)" (angular#38101)

This reverts commit 406f801.

The reason for the revert is the breakage in i18n subsystem in g3.

PR Close angular#38101
@petebacondarwin
Copy link
Member

@AndrewKushnir - what are the next steps for this PR?

@AndrewKushnir
Copy link
Contributor

Hey @petebacondarwin, thanks for the note.
I believe the next step is to test the changes in g3 again (and run a global TAP to verify)...

@kyliau @dgp1130 do you plan to look into this or should we close the PR for now?

@laurentlb
Copy link
Contributor

I think this can be reverted until someone picks up the cleanup work in google3 (cc @lberki).

@kyliau
Copy link
Contributor Author

kyliau commented Dec 3, 2020

The cleanup work mentioned by @laurentlb is tracked in b/160134064. Meanwhile I'll close this.

@kyliau kyliau closed this Dec 3, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2021
@pullapprove pullapprove bot added the area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) label Jan 3, 2021
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: bazel Issues related to the published `@angular/bazel` build rules area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes state: blocked target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants