New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove obsolete Bazel function ctx.new_file #38080
Conversation
The function was removed by default in Bazel 0.27. It is still accessible with the flag `--incompatible_new_actions_api` (which is set in Google code base), but the flag will be deleted very soon. This change should be a no-op for Bazel users. The change was tested in Google (cl/318277076) and should be safe as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the same as the previous PR, you can probably just force successful presubmit and link to the old ID rather than running a new one.
cc: @laurentlb this is good to go, thank you! |
FYI, I had to rollback this change due to the issues in Google's codebase (see PR #38101), so I'me reopening this PR. |
The function was removed by default in Bazel 0.27. It is still accessible with the flag `--incompatible_new_actions_api` (which is set in Google code base), but the flag will be deleted very soon. This change should be a no-op for Bazel users. The change was tested in Google (cl/318277076) and should be safe as well. PR Close angular#38080
…8080)" (angular#38101) This reverts commit 406f801. The reason for the revert is the breakage in i18n subsystem in g3. PR Close angular#38101
@AndrewKushnir - what are the next steps for this PR? |
Hey @petebacondarwin, thanks for the note. @kyliau @dgp1130 do you plan to look into this or should we close the PR for now? |
I think this can be reverted until someone picks up the cleanup work in google3 (cc @lberki). |
The cleanup work mentioned by @laurentlb is tracked in b/160134064. Meanwhile I'll close this. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is a resurrection of #37759
I made a mistake in git push and accidentally closed the PR.
The function was removed by default in Bazel 0.27.
It is still accessible with the flag
--incompatible_new_actions_api
(which is set in Google code base), but the flag will be deleted very soon.
This change should be a no-op for Bazel users. The change was tested in
Google (cl/318277076) and should be safe as well.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information