Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-infra): correct build setup for dev-infra #38815

Closed
wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

Correct's the missing dependencies and incorrect build dependencies for the
dev-infra bazel targets.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Sep 11, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 11, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dev-infra/tmpl-package.json Outdated Show resolved Hide resolved
@josephperrott josephperrott force-pushed the fix-dev-infra branch 2 times, most recently from 1ee7722 to 9011f0f Compare September 11, 2020 20:21
Correct's the missing dependencies and incorrect build dependencies for the
dev-infra bazel targets.
AndrewKushnir pushed a commit that referenced this pull request Sep 11, 2020
Correct's the missing dependencies and incorrect build dependencies for the
dev-infra bazel targets.

PR Close #38815
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2020
@josephperrott josephperrott deleted the fix-dev-infra branch August 31, 2023 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants