Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: do not require g3 checks for the changes in ngtsc/sourcemaps folder #39035

Closed
wants to merge 1 commit into from
Closed

ci: do not require g3 checks for the changes in ngtsc/sourcemaps folder #39035

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates ngbot config to avoid requesting google3 presubmit for the changes in
the packages/compiler-cli/src/ngtsc/sourcemaps folder (which is not synced into google3).

PR Type

What kind of change does this PR introduce?

  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
ci: do not require g3 checks for the changes in ngtsc/sourcemaps fo…
7914209 
…lder

This commit updates ngbot config to avoid requesting google3 presubmit for the changes in
the `packages/compiler-cli/src/ngtsc/sourcemaps` folder (which is not synced into google3).
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 29, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 29, 2020
@AndrewKushnir AndrewKushnir mentioned this pull request Sep 29, 2020
Closed
josephperrott
josephperrott approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 29, 2020
alxhub pushed a commit that referenced this pull request Sep 30, 2020
@AndrewKushnir @alxhub
ci: do not require g3 checks for the changes in ngtsc/sourcemaps fo…
8292e1c 
…lder (#39035)

This commit updates ngbot config to avoid requesting google3 presubmit for the changes in
the `packages/compiler-cli/src/ngtsc/sourcemaps` folder (which is not synced into google3).

PR Close #39035
@alxhub alxhub closed this in 393ce55 Sep 30, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndrewKushnir @josephperrott @googlebot