fix(core): migrate relative link resolution with single quotes #39102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a roll forward of angular#39082, using `ts.createIdentifier(`'legacy'`)` as a cross-version compatible way of making a single quoted string literal. Migrated code now uses single quotes, which is in line with the default linting options, so there is no lint error after migration.
dgp1130
added
target: major
atscott
approved these changes
Oct 5, 2020
alan-agius4
added
the
merge: caretaker note
alan-agius4
removed
the
merge: caretaker note
crisbeto
reviewed
Oct 8, 2020
| @@ -45,7 +45,7 @@ export class RelativeLinkResolutionTransform { | |||
| return literal; | |||
| } | |||
| const legacyExpression = | |||
| ts.createPropertyAssignment(RELATIVE_LINK_RESOLUTION, ts.createStringLiteral('legacy')); | |||
| ts.createPropertyAssignment(RELATIVE_LINK_RESOLUTION, ts.createIdentifier(`'legacy'`)); | |||
There was a problem hiding this comment.
nit: it might be a good idea to leave a comment about why we use createIdentifier here.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a roll forward of #39082, using
ts.createIdentifier(`'legacy'`)as a cross-version compatible way of makinga single quoted string literal.
Migrated code now uses single quotes, which is in line with the default linting options, so there is no lint error after
migration.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Migrating code for legacy relative link resolution generates double quotes, which is against the default style guide and leads to a lint warning in the CLI. This is also a CI failure in the CLI repo.
Issue Number: N/A
What is the new behavior?
Migrating code for legacy relative link resolution now generates single quotes, which is in line with the style guide and no longer generates a lint warning.
Does this PR introduce a breaking change?