fix(zone.js): jest getRealSystemTime should return native time #39127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
added
the
target: major
JiaLiPassion
force-pushed
the
jest-fix-1
branch
2 times, most recently
from
aaefaa4
to
79a5f14
Compare
`jest.getRealSystemTime()` should return native `Date.now()`, the current implemenation return the wrong value which is the fixed number.
JiaLiPassion
force-pushed
the
jest-fix-1
branch
2 times, most recently
from
090d3c7
to
a42f2fa
Compare
In `FakeAsyncZoneSpec`, there are several variables and APIs to identify different times, and the names are confusing, in this commit, they are renamed for more clear understandings. 1. currentTickTime, the tick millis advanced. 2. getFakeBaseSystemTime(), return the fake base system time. 3. setFakeBaseSystemTime(), set the fake base system time. 4. getRealSystemTime(), get the underlying native system time.
JiaLiPassion
force-pushed
the
jest-fix-1
branch
from
a42f2fa
to
8a68669
Compare
mhevery
approved these changes
Oct 12, 2020
atscott
pushed a commit
that referenced
this pull request
Oct 13, 2020
…ec (#39127) In `FakeAsyncZoneSpec`, there are several variables and APIs to identify different times, and the names are confusing, in this commit, they are renamed for more clear understandings. 1. currentTickTime, the tick millis advanced. 2. getFakeBaseSystemTime(), return the fake base system time. 3. setFakeBaseSystemTime(), set the fake base system time. 4. getRealSystemTime(), get the underlying native system time. PR Close #39127
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest.getRealSystemTime()should return nativeDate.now(), thecurrent implemenation return the wrong value which is the fixed
number.