Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): avoid duplicate diagnostics about unknown pipes #39517

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): avoid duplicate diagnostics about unknown pipes #39517

wants to merge 1 commit into from

Commits on Oct 30, 2020

  1. fix(compiler-cli): avoid duplicate diagnostics about unknown pipes 

    TCB generation occasionally transforms binding expressions twice, which can
result in a `BindingPipe` operation being `resolve()`'d multiple times. When
the pipe does not exist, this caused multiple OOB diagnostics to be recorded
about the missing pipe.

This commit fixes the problem by making the OOB recorder track which pipe
expressions have had diagnostics produced already, and only producing them
once per expression.
    @alxhub
    alxhub committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    49e1abd View commit details
    Browse the repository at this point in the history