Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Typings): Output public constructors in .d.ts files #3963

Closed
wants to merge 1 commit into from
Closed

fix(Typings): Output public constructors in .d.ts files #3963

wants to merge 1 commit into from

Conversation

jteplitz
Copy link
Contributor

@jteplitz jteplitz commented Sep 2, 2015

Closes #3926.

@jteplitz jteplitz added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 2, 2015
@jteplitz jteplitz mentioned this pull request Sep 4, 2015
Closed
@jteplitz jteplitz assigned jeffbcross and unassigned alexeagle Sep 8, 2015
@jteplitz jteplitz added state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 8, 2015
@jteplitz jteplitz added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Sep 8, 2015
jeffbcross
jeffbcross reviewed Sep 9, 2015
View reviewed changes
modules/angular2/render.ts
@@ -4,4 +4,23 @@
*
* JavaScript users should import from angular2/core.
*/
export * from './src/core/render';
export {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is being filtered out here?

@jeffbcross
Copy link
Contributor

Looks good once you change the export at angular2/render.ts to be export * from './src/core/render'

@jeffbcross jeffbcross added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 9, 2015
@jeffbcross jeffbcross assigned jteplitz and unassigned jeffbcross Sep 9, 2015
@jeffbcross jeffbcross removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 9, 2015
@jteplitz jteplitz removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 9, 2015
@jteplitz jteplitz closed this in 1926335 Sep 10, 2015
nponiros added a commit to jsperts/presentations that referenced this pull request Sep 10, 2015
@nponiros
Fix npm build task
5d56333 
Workaround an issue with the angular typings by exiting with 0 always.
Currently the typings do not contain public constructors which results
in an error during compilation as the compiler does not know the
arguments expected by the Control constructor.
See issue angular/angular#3938
Pull request angular/angular#3963
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jteplitz jteplitz

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dgeni doesn't output constructors in .d.ts files
4 participants
@jteplitz @jeffbcross @alexeagle @googlebot