fix(forms): more precise handling of onCollectionChange callbacks
#39685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Form controls have internal API that allows subscribing to changes in a data collection (for FormGroups and FormArrays), when a new control is added to a collection or existing one is removed. This internal API is used inside FormGroupDirective to trigger DOM updates. The problem with the current API is that there is no way to append a callback or remove a particular one (for ex. a callback that belongs to a directive that is being removed). Instead, new `onCollectionChange` callback always resets existing one. This commit updates the logic of `onCollectionChange` callback handling to provide an ability to add and remove particular callbacks without loosing previous callbacks. It resolves some of the problems in case a FormGroup instance is shared between different instances of Forms directives as well as allowing for better cleanup mechanisms to be implemented in followup PRs.
AndrewKushnir
added
type: bug/fix
state: WIP
area: forms
target: patch
AndrewKushnir
changed the title
onCollectionChange callbacksonCollectionChange callbacks
This was referenced Nov 14, 2020
|
Quick update: it turned out that this change is quite break-y and we would not be able to land it in minor or patch versions (only in major). I'll need to do more investigation to figure out how that would affect #39235. |
|
Closing this PR for now as it's not needed at this moment and improving |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form controls have internal API that allows subscribing to changes in a data collection (for FormGroups and
FormArrays), when a new control is added to a collection or existing one is removed. This internal API is used
inside FormGroupDirective to trigger DOM updates. The problem with the current API is that there is no way to
append a callback or remove a particular one (for ex. a callback that belongs to a directive that is being
removed). Instead, new
onCollectionChangecallback always resets existing one.This commit updates the logic of
onCollectionChangecallback handling to provide an ability to add and removeparticular callbacks without loosing previous callbacks. It resolves some of the problems in case a FormGroup
instance is shared between different instances of Forms directives as well as allowing for better cleanup
mechanisms to be implemented in followup PRs.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?