build(docs-infra): update docs examples to Angular v11.0.1 #39818

gkalpak · 2020-11-23T19:49:49Z

This PR updates the docs examples to Angular v11.0.1. In addition to updating the dependencies versions, it also updates the project's structure and config to more closely match what a new v11 CLI app would look like. See, also, the diff between a basic v10.1.3 CLI app and a v11.0.2 one.

It also disables the Selenium Promise Manager (as seen here) and switches all e2e tests to async/await (to align with new CLI v11 apps).

_{(Supercedes #39787.)}

This commit updates the docs examples to Angular v11.0.1. In addition to updating the dependencies versions, it also updates the project's structure and config to more closely match what a new v11 CLI app would look like. See, also, the [diff][1] between a basic v10.1.3 CLI app and a v11.0.2 one. NOTE: I refrained from disabling the Selenium Promise Manager (as seen [here][2]) and switching all e2e tests to `async/await`, because that is a big change and should be done in a separate commit/PR. [1]: https://github.com/cexbrayat/angular-cli-diff/compare/10.1.3..11.0.2 [2]: cexbrayat/angular-cli-diff@10.1.3...11.0.2#diff-dbd675d74087d57cd084d6dd6ae24ae2eeff2ff0122680e12916052f8a843a29

Previously, the test made no meaningful assertion. It seems that the intention was to ensure that some elements were present on the page, but all the assertions did was verify that the corresponding `ElementFinder`s were defined. The `ElementFinder`s would always be defined, even if there were no corresponding elements on the page. In fact, some of the `ElementFinder` selectors were incorrect, so they did not match any actual elements. This commit fixes the tests by fixing the `ElementFinder` selectors and asserting that the elements are actually present on the page.

Previously, the tests made no meaningful assertions. It seems that the intention was to ensure that some elements were present on the page, but all the assertions did was verify that the corresponding `ElementFinder`s were defined. The `ElementFinder`s would always be defined, even if there were no corresponding elements on the page. In fact, some of the `ElementFinder` selectors were incorrect, so they did not match any actual elements. This commit fixes the tests by fixing the `ElementFinder` selectors and asserting that the elements are actually present on the page.

This commit removes some code that is no longer necessary for the `upgrade-module` docs example e2e tests to run. It used to be necessary in earlier version of Protractor but not any more.

…es e2e tests This commit disables the Selenium Promise Manager when running e2e tests for docs examples in order to more closely align them with new apps created with CLI v11. This change requires that any async operations in tests are handled explicitly (e.g. using `async/await` or `Promise#then()`).

mary-poppins · 2020-11-23T20:05:23Z

You can preview 7b3106d at https://pr39818-7b3106d.ngbuilds.io/.

petebacondarwin

Reviewed-for: docs-infra

petebacondarwin · 2020-11-23T20:32:07Z

aio/content/examples/testing/src/app/demo/demo.testbed.spec.ts

@@ -144,7 +144,7 @@ describe('demo (with TestBed):', () => {
    );
  });

-  describe('using async(inject) within beforeEach', () => {
+  describe('using waitForAsync(inject) within beforeEach', () => {


Interesting that this bit of code does not appear in any guides!

It does (e.g. here, here and here), but it was already updated there.

Not this specific line of code, it doesn't :-)

Oh, yeah, not this line of code. I meant waitForAsync() in general.
Overall, very few lines from e2e tests are included in the docs as code snippets.

petebacondarwin

Reviewed-for: global-docs-approvers

petebacondarwin

Reviewed-for: public_api

petebacondarwin

Reviewed-for: public-api

IgorMinar

Reviewed-for: global-approvers

This commit updates the docs examples to Angular v11.0.1. In addition to updating the dependencies versions, it also updates the project's structure and config to more closely match what a new v11 CLI app would look like. See, also, the [diff][1] between a basic v10.1.3 CLI app and a v11.0.2 one. NOTE: I refrained from disabling the Selenium Promise Manager (as seen [here][2]) and switching all e2e tests to `async/await`, because that is a big change and should be done in a separate commit/PR. [1]: https://github.com/cexbrayat/angular-cli-diff/compare/10.1.3..11.0.2 [2]: cexbrayat/angular-cli-diff@10.1.3...11.0.2#diff-dbd675d74087d57cd084d6dd6ae24ae2eeff2ff0122680e12916052f8a843a29 PR Close #39818

Previously, the test made no meaningful assertion. It seems that the intention was to ensure that some elements were present on the page, but all the assertions did was verify that the corresponding `ElementFinder`s were defined. The `ElementFinder`s would always be defined, even if there were no corresponding elements on the page. In fact, some of the `ElementFinder` selectors were incorrect, so they did not match any actual elements. This commit fixes the tests by fixing the `ElementFinder` selectors and asserting that the elements are actually present on the page. PR Close #39818

…39818) Previously, the tests made no meaningful assertions. It seems that the intention was to ensure that some elements were present on the page, but all the assertions did was verify that the corresponding `ElementFinder`s were defined. The `ElementFinder`s would always be defined, even if there were no corresponding elements on the page. In fact, some of the `ElementFinder` selectors were incorrect, so they did not match any actual elements. This commit fixes the tests by fixing the `ElementFinder` selectors and asserting that the elements are actually present on the page. PR Close #39818

…ts (#39818) This commit removes some code that is no longer necessary for the `upgrade-module` docs example e2e tests to run. It used to be necessary in earlier version of Protractor but not any more. PR Close #39818

…es e2e tests (#39818) This commit disables the Selenium Promise Manager when running e2e tests for docs examples in order to more closely align them with new apps created with CLI v11. This change requires that any async operations in tests are handled explicitly (e.g. using `async/await` or `Promise#then()`). PR Close #39818

Previously, the test made no meaningful assertion. It seems that the intention was to ensure that some elements were present on the page, but all the assertions did was verify that the corresponding `ElementFinder`s were defined. The `ElementFinder`s would always be defined, even if there were no corresponding elements on the page. In fact, some of the `ElementFinder` selectors were incorrect, so they did not match any actual elements. This commit fixes the tests by fixing the `ElementFinder` selectors and asserting that the elements are actually present on the page. PR Close #39818

…39818) Previously, the tests made no meaningful assertions. It seems that the intention was to ensure that some elements were present on the page, but all the assertions did was verify that the corresponding `ElementFinder`s were defined. The `ElementFinder`s would always be defined, even if there were no corresponding elements on the page. In fact, some of the `ElementFinder` selectors were incorrect, so they did not match any actual elements. This commit fixes the tests by fixing the `ElementFinder` selectors and asserting that the elements are actually present on the page. PR Close #39818

…ts (#39818) This commit removes some code that is no longer necessary for the `upgrade-module` docs example e2e tests to run. It used to be necessary in earlier version of Protractor but not any more. PR Close #39818

…es e2e tests (#39818) This commit disables the Selenium Promise Manager when running e2e tests for docs examples in order to more closely align them with new apps created with CLI v11. This change requires that any async operations in tests are handled explicitly (e.g. using `async/await` or `Promise#then()`). PR Close #39818

angular-automatic-lock-bot · 2020-12-26T16:43:18Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gkalpak added 5 commits November 23, 2020 20:16

test(docs-infra): remove redundant code from upgrade-module e2e tests

f9771e9

This commit removes some code that is no longer necessary for the `upgrade-module` docs example e2e tests to run. It used to be necessary in earlier version of Protractor but not any more.

google-cla bot added the cla: yes label Nov 23, 2020

gkalpak added area: build & ci Related the build and CI infrastructure of the project comp: docs-infra target: patch This PR is targeted for the next patch release and removed cla: yes labels Nov 23, 2020

ngbot bot modified the milestone: needsTriage Nov 23, 2020

google-cla bot added the cla: yes label Nov 23, 2020

This comment has been minimized.

Sign in to view

gkalpak modified the milestones: needsTriage, docs-infra-tooling Nov 23, 2020

gkalpak added this to REVIEW in docs-infra Nov 23, 2020

gkalpak marked this pull request as ready for review November 23, 2020 20:15

pullapprove bot requested review from alxhub, AndrewKushnir, atscott, IgorMinar, jelbourn and mhevery November 23, 2020 20:15

petebacondarwin approved these changes Nov 23, 2020

View reviewed changes

IgorMinar removed request for atscott, jelbourn, alxhub and IgorMinar November 24, 2020 22:46

pullapprove bot requested review from alxhub, IgorMinar, atscott and jelbourn November 24, 2020 22:46

IgorMinar approved these changes Nov 24, 2020

View reviewed changes

IgorMinar removed request for alxhub, atscott and jelbourn November 24, 2020 22:47

IgorMinar added the action: merge The PR is ready for merge by the caretaker label Nov 24, 2020

AndrewKushnir closed this in 3d2c2c4 Nov 24, 2020

gkalpak deleted the build-aio-upgrade-examples-to-v11 branch November 25, 2020 11:00

gkalpak mentioned this pull request Nov 28, 2020

build: flakes in e2e test in test_aio(_local(_viewengine)) CI jobs #39872

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2020

pullapprove bot removed area: build & ci Related the build and CI infrastructure of the project comp: docs-infra labels Dec 26, 2020

ngbot bot removed this from the docs-infra-tooling milestone Dec 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(docs-infra): update docs examples to Angular v11.0.1 #39818

build(docs-infra): update docs examples to Angular v11.0.1 #39818

gkalpak commented Nov 23, 2020 •

edited

This comment has been minimized.

mary-poppins commented Nov 23, 2020

petebacondarwin left a comment •

edited

petebacondarwin Nov 23, 2020

gkalpak Nov 23, 2020

petebacondarwin Nov 23, 2020

gkalpak Nov 24, 2020

petebacondarwin left a comment

petebacondarwin left a comment

petebacondarwin left a comment

IgorMinar left a comment

angular-automatic-lock-bot bot commented Dec 26, 2020

build(docs-infra): update docs examples to Angular v11.0.1 #39818

build(docs-infra): update docs examples to Angular v11.0.1 #39818

Conversation

gkalpak commented Nov 23, 2020 • edited

This comment has been minimized.

mary-poppins commented Nov 23, 2020

petebacondarwin left a comment • edited

Choose a reason for hiding this comment

petebacondarwin Nov 23, 2020

Choose a reason for hiding this comment

gkalpak Nov 23, 2020

Choose a reason for hiding this comment

petebacondarwin Nov 23, 2020

Choose a reason for hiding this comment

gkalpak Nov 24, 2020

Choose a reason for hiding this comment

petebacondarwin left a comment

Choose a reason for hiding this comment

petebacondarwin left a comment

Choose a reason for hiding this comment

petebacondarwin left a comment

Choose a reason for hiding this comment

IgorMinar left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Dec 26, 2020

gkalpak commented Nov 23, 2020 •

edited

petebacondarwin left a comment •

edited