Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-infra): correct the environment variable to skip husky during #40025

Conversation

josephperrott
Copy link
Member

With the migration to husky@5, the environment variable used to skip husky changed from
HUSKY_SKIP_HOOKS to HUSKY. To continue skipping husky during the merge process as
expected, the environment variable used is updated.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Dec 8, 2020
@ngbot ngbot bot modified the milestone: Backlog Dec 8, 2020
@google-cla google-cla bot added the cla: yes label Dec 8, 2020
… merge

With the migration to husky@5, the environment variable used to skip husky changed from
`HUSKY_SKIP_HOOKS` to `HUSKY`.  To continue skipping husky during the merge process as
expected, the environment variable used is updated.
@mhevery mhevery closed this in 634c393 Dec 9, 2020
mhevery pushed a commit that referenced this pull request Dec 9, 2020
… merge (#40025)

With the migration to husky@5, the environment variable used to skip husky changed from
`HUSKY_SKIP_HOOKS` to `HUSKY`.  To continue skipping husky during the merge process as
expected, the environment variable used is updated.

PR Close #40025
zarend pushed a commit to zarend/angular that referenced this pull request Dec 10, 2020
… merge (angular#40025)

With the migration to husky@5, the environment variable used to skip husky changed from
`HUSKY_SKIP_HOOKS` to `HUSKY`.  To continue skipping husky during the merge process as
expected, the environment variable used is updated.

PR Close angular#40025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2021
@josephperrott josephperrott deleted the correct-husky-skip-env-variable branch August 31, 2023 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants