fix(dev-infra): detect multiple target labels as invalid #40156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple target labels are applied to a PR, it should be considered invalid as our tooling does not support a single PR targetting multiple trains/versions.
josephperrott
added
action: review
gkalpak
reviewed
Dec 16, 2020
There was a problem hiding this comment.
our tooling does not support a single PR targetting multiple trains/versions
I think this part of the commit sounds a little confusing. We do support merging into multiple trains/versions. For example, the target: patch label could result in merging into master, RC and patch. The commit message could be a little more clear on what the tooling does not support (multiple target labels?).
Otherwise lgtm 👍
gkalpak
requested changes
Jan 8, 2021
gkalpak
approved these changes
Jan 8, 2021
josephperrott
added
action: merge
atscott
pushed a commit
that referenced
this pull request
Jan 11, 2021
When multiple target labels are applied to a PR, it should be considered invalid as our tooling does not support a single PR targetting multiple trains/versions. PR Close #40156
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple target labels are applied to a PR, it should be considered
invalid as our tooling does not support a single PR targetting multiple
trains/versions.