feat(compiler): add change detector generation #4057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
added
the
action: review
tbosch
force-pushed
the
change_compiler
branch
3 times, most recently
from
758e221
to
6ab3b0d
Compare
| createChangeDetectorDefinitions(componentType, strategy, this._genConfig, parsedTemplate); | ||
| if (IS_DART) { | ||
| return changeDetectorDefinitions.map( | ||
| definition => (dispatcher) => |
There was a problem hiding this comment.
first create ProtoChangeDetector and use it for all .instantiate methods
tbosch
added
pr_state: LGTM
action: cleanup
|
Reviewed with @vsavkin in person |
tbosch
force-pushed
the
change_compiler
branch
3 times, most recently
from
59607fd
to
a7833c2
Compare
Runtime and Codegen. Part of angular#3605
tbosch
force-pushed
the
change_compiler
branch
from
a7833c2
to
a864e83
Compare
|
Merging PR #4057 on behalf of @tbosch to branch presubmit-tbosch-pr-4057. |
tbosch
removed
the
action: cleanup
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime and Codegen.
Part of #3605