Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rulesnodejs@3.1.0 #40710

Closed
wants to merge 17 commits into from
Closed

Update to rulesnodejs@3.1.0 #40710

wants to merge 17 commits into from
+454 −415

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Feb 4, 2021 •
edited

See individual commits.

See rules_nodejs#stricter-ts-typechecks for more information on changes to castings involving JSON.parse

@josephperrott josephperrott added area: benchpress area: build & ci Related the build and CI infrastructure of the project area: testing Issues related to Angular testing features, such as TestBed action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n area: router area: zones target: patch This PR is targeted for the next patch release area: bazel Issues related to the published `@angular/bazel` build rules area: service-worker Issues related to the @angular/service-worker package area: elements Issues related to Angular Elements comp: ts-api-guardian area: compiler Issues related to `ngc`, Angular's template compiler area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Feb 4, 2021
@ngbot ngbot bot modified the milestone: Backlog Feb 4, 2021
@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@josephperrott josephperrott marked this pull request as ready for review February 5, 2021 00:16
AndrewKushnir
AndrewKushnir reviewed Feb 5, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephperrott could you plz share a link (may be add to a PR description) to a change that triggered JSON.parse type cast (as an additional context for CR)?

alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(localize): update type castings for JSON.parse usage (#40710)
57d46d4 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(elements): update type castings for JSON.parse usage (#40710)
cd1b764 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update type castings for JSON.parse usage (#40710)
bc7be8f 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler): update type castings for JSON.parse usage (#40710)
ceafef1 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(benchpress): update type castings for JSON.parse usage (#40710)
52da337 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update type castings for JSON.parse usage (#40710)
36a3a6a 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update type castings for JSON.parse usage (#40710)
305d41c 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update build tooling for latest changes in rules_nodejs (#…
621c32d 
…40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update build tooling for latest changes in rules_node…
1e06407 
…js (#40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update ngcc integration tests for latest changes i…
a4e396d 
…n rules_nodejs (#40710)

Update the ngcc integration tests to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
build: update to rules_nodejs@3.1.0 (#40710)
53adebd 
Update to the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update integration test to use rules_nodejs@3.1.0 (#40710)
a3e556f 
Update the integraiton tests for bazel to the latest rules_nodejs version.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
build: update tools directory for latest changes in rules_nodejs (#40710
75b3f9f 
)

Update the scripts/tooling in the tools directory to handle the changes in the latest
version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(zone.js): update build tooling for latest changes in rules_nodejs (…
b02136a 
…#40710)

Update the zone.js build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(service-worker): update type castings for JSON.parse usage (#40710)
62845f3 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(router): update type castings for JSON.parse usage (#40710)
456a991 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(platform-browser): update type castings for JSON.parse usage (#40710
3320373 
)

Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(localize): update type castings for JSON.parse usage (#40710)
4661d90 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(elements): update type castings for JSON.parse usage (#40710)
547f8a0 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update type castings for JSON.parse usage (#40710)
72c2f06 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler): update type castings for JSON.parse usage (#40710)
9e786f9 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(benchpress): update type castings for JSON.parse usage (#40710)
020a576 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update type castings for JSON.parse usage (#40710)
dc9c50d 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update type castings for JSON.parse usage (#40710)
ddf12e4 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update build tooling for latest changes in rules_nodejs (#…
7e1eac3 
…40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update build tooling for latest changes in rules_node…
d568a8d 
…js (#40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update ngcc integration tests for latest changes i…
3c0846a 
…n rules_nodejs (#40710)

Update the ngcc integration tests to handle the changes in the latest version of rules_nodejs.

PR Close #40710
@josephperrott josephperrott deleted the update-rulesnodejs-3.1.0 branch February 9, 2021 20:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 left review comments

@AndrewKushnir AndrewKushnir AndrewKushnir left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules area: benchpress area: build & ci Related the build and CI infrastructure of the project area: compiler Issues related to `ngc`, Angular's template compiler area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) area: elements Issues related to Angular Elements area: i18n area: router area: service-worker Issues related to the @angular/service-worker package area: testing Issues related to Angular testing features, such as TestBed area: zones cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@josephperrott @alan-agius4 @petebacondarwin @IgorMinar @AndrewKushnir