Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify that support schedule is subject to change #40770

Closed
wants to merge 1 commit into from

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Feb 9, 2021

Initially raised due to #39509, this change updates our "Support policy and schedule" with the same disclaimer from the "Release frequency" section above.

I debated with changing the actual numbers in this section. We could change the docs to say "17 months" support and "5 months" active support to codify the fact that we decided that -1 month is acceptable, but that felt like it wasn't really representative of the goal.

@ngbot ngbot bot modified the milestone: Backlog Feb 9, 2021
@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Feb 9, 2021
@mary-poppins
Copy link

You can preview a93c810 at https://pr40770-a93c810.ngbuilds.io/.

Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can shorten up this disclaimer considerably. I've offered a suggestion. Some additional information:

  1. The text is already in an alert; using 'disclaimer' is unnecessary.
  2. The phrase "ensure delivery of a high-quality platform" is also not needed. Would we ever delay a release to lower its quality? :)
  3. Using first person plural is usually unnecessary and can be distracting.
    Let me know if you have any questions!

Comment on lines 73 to 74
Disclaimer: Dates are offered as general guidance and will be adjusted by us when necessary to
ensure delivery of a high-quality platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Disclaimer: Dates are offered as general guidance and will be adjusted by us when necessary to
ensure delivery of a high-quality platform.
Dates are offered as general guidance and subject to change.

Comment on lines 96 to 97
Disclaimer: Dates are offered as general guidance and will be adjusted by us when necessary to
ensure delivery of a high-quality platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Disclaimer: Dates are offered as general guidance and will be adjusted by us when necessary to
ensure delivery of a high-quality platform.
Dates are offered as general guidance and subject to change.


</div>

All of our major releases are typically supported for 18 months.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All of our major releases are typically supported for 18 months.
All major releases are typically supported for 18 months.

@jelbourn jelbourn force-pushed the support-window branch 2 times, most recently from 25354a4 to bee44cb Compare February 10, 2021 22:53
@mary-poppins
Copy link

You can preview bee44cb at https://pr40770-bee44cb.ngbuilds.io/.

Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Reviewed-for: global-docs-approvers

Initially raised due to angular#39509, this change updates our
"Support policy and schedule" with the same disclaimer
from the "Release frequency" section above.
@mary-poppins
Copy link

You can preview 4b2dd82 at https://pr40770-4b2dd82.ngbuilds.io/.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2021
josephperrott pushed a commit that referenced this pull request Feb 13, 2021
Initially raised due to #39509, this change updates our
"Support policy and schedule" with the same disclaimer
from the "Release frequency" section above.

PR Close #40770
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants