Miscellaneous compiler/core refactorings #41040

petebacondarwin · 2021-03-01T21:12:17Z

See commits...

petebacondarwin · 2021-03-02T12:08:01Z

packages/core/src/render3/definition.ts

@@ -288,67 +288,65 @@ export function ɵɵdefineComponent<T>(componentDefinition: {
   * The set of schemas that declare elements to be allowed in the component's template.
   */
  schemas?: SchemaMetadata[] | null;
-}): never {


Most of the changes in this file are just whitespace indentation.

JoostK

Type in the last commit:

Previously, ɵɵgetFactoryOf() was "privately" published from
@angular/core since in the passed -> past

packages/compiler/src/aot/compiler.ts

packages/core/test/render3/jit_environment_spec.ts

…d associated code

These constants were created in a very early phase of Ivy development. They have never been used in the framework, no the build-optimizer tool.

AndrewKushnir · 2021-03-03T16:53:49Z

Presubmit.

mhevery

reviewed-for: global-approvers

The `accessExportScope()` function is not used anymore. PR Close #41040

…iated code (#41040) This method does not appear to be used in the project. This commit removes it and code that it exclusively depended upon, or depended upon it. PR Close #41040

This function is never actually generated directly so it can be removed from the context passed to the JIT compiler. PR Close #41040

Previously, `ɵɵgetFactoryOf()` was "privately" published from `@angular/core` since in the past it was assumed that this might be an instruction generated by the compiler. This is not currently the case, so this commit removes it from the private exports and renames it to indicate that it is a local helper function. PR Close #41040

…1040) These constants were created in a very early phase of Ivy development. They have never been used in the framework, no the build-optimizer tool. PR Close #41040

…ies (#41040) Before `unknown` was available, the `never` type was used to discourage application developers from using "private" properties. The `unknown` type is much better suited for this. PR Close #41040

The `accessExportScope()` function is not used anymore. PR Close #41040

…iated code (#41040) This method does not appear to be used in the project. This commit removes it and code that it exclusively depended upon, or depended upon it. PR Close #41040

This function is never actually generated directly so it can be removed from the context passed to the JIT compiler. PR Close #41040

Previously, `ɵɵgetFactoryOf()` was "privately" published from `@angular/core` since in the past it was assumed that this might be an instruction generated by the compiler. This is not currently the case, so this commit removes it from the private exports and renames it to indicate that it is a local helper function. PR Close #41040

…1040) These constants were created in a very early phase of Ivy development. They have never been used in the framework, no the build-optimizer tool. PR Close #41040

angular-automatic-lock-bot · 2021-04-04T16:07:57Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

google-cla bot added the cla: yes label Mar 1, 2021

petebacondarwin added area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime refactoring Issue that involves refactoring or code-cleanup state: WIP target: patch This PR is targeted for the next patch release labels Mar 1, 2021

ngbot bot modified the milestone: Backlog Mar 1, 2021

petebacondarwin force-pushed the compiler-refactorings branch 4 times, most recently from cc3c89e to 1ac20ce Compare March 2, 2021 11:45

petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Mar 2, 2021

petebacondarwin marked this pull request as ready for review March 2, 2021 12:06

pullapprove bot requested a review from AndrewKushnir March 2, 2021 12:06

petebacondarwin requested review from alxhub, JoostK and mhevery and removed request for AndrewKushnir March 2, 2021 12:06

petebacondarwin commented Mar 2, 2021

View reviewed changes

petebacondarwin mentioned this pull request Mar 2, 2021

refactor(core): remove getFactoryOf() from public facing role #41049

Closed

JoostK reviewed Mar 2, 2021

View reviewed changes

packages/compiler/src/aot/compiler.ts Show resolved Hide resolved

packages/compiler/src/aot/compiler.ts Show resolved Hide resolved

packages/core/test/render3/jit_environment_spec.ts Outdated Show resolved Hide resolved

petebacondarwin force-pushed the compiler-refactorings branch from c454157 to 19c04f6 Compare March 2, 2021 20:53

petebacondarwin added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Mar 3, 2021

petebacondarwin requested a review from JoostK March 3, 2021 07:26

petebacondarwin mentioned this pull request Mar 3, 2021

refactor(compiler): move injector factory #41022

Closed

petebacondarwin added 3 commits March 3, 2021 11:52

fixup! refactor(core): remove getFactoryOf from angularCoreDiEnv

6478dd0

fixup! refactor(compiler): remove unused emitAllPartialModules() an…

181522b

…d associated code

refactor(compiler): remove unused __BUILD_OPTIMIZER_* constants

58c692c

These constants were created in a very early phase of Ivy development. They have never been used in the framework, no the build-optimizer tool.

petebacondarwin force-pushed the compiler-refactorings branch from 19c04f6 to 58c692c Compare March 3, 2021 11:52

mhevery approved these changes Mar 3, 2021

View reviewed changes

mhevery removed action: presubmit The PR is in need of a google3 presubmit action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 3, 2021

mhevery approved these changes Mar 3, 2021

View reviewed changes

JoostK approved these changes Mar 3, 2021

View reviewed changes

zarend added action: presubmit The PR is in need of a google3 presubmit and removed action: merge The PR is ready for merge by the caretaker labels Mar 3, 2021

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 3, 2021

petebacondarwin removed the request for review from alxhub March 3, 2021 19:29

AndrewKushnir closed this in 0f818f3 Mar 4, 2021

AndrewKushnir pushed a commit that referenced this pull request Mar 4, 2021

refactor(compiler): remove unused function (#41040)

7f24937

The `accessExportScope()` function is not used anymore. PR Close #41040

AndrewKushnir pushed a commit that referenced this pull request Mar 4, 2021

refactor(core): remove getFactoryOf from angularCoreDiEnv (#41040)

326f167

This function is never actually generated directly so it can be removed from the context passed to the JIT compiler. PR Close #41040

AndrewKushnir pushed a commit that referenced this pull request Mar 4, 2021

refactor(compiler): remove unused function (#41040)

d7f4f1b

The `accessExportScope()` function is not used anymore. PR Close #41040

AndrewKushnir pushed a commit that referenced this pull request Mar 4, 2021

refactor(core): remove getFactoryOf from angularCoreDiEnv (#41040)

09d50fb

This function is never actually generated directly so it can be removed from the context passed to the JIT compiler. PR Close #41040

petebacondarwin deleted the compiler-refactorings branch March 4, 2021 20:57

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Miscellaneous compiler/core refactorings #41040

Miscellaneous compiler/core refactorings #41040

petebacondarwin commented Mar 1, 2021

petebacondarwin Mar 2, 2021

JoostK left a comment

AndrewKushnir commented Mar 3, 2021

mhevery left a comment

angular-automatic-lock-bot bot commented Apr 4, 2021

Miscellaneous compiler/core refactorings #41040

Miscellaneous compiler/core refactorings #41040

Conversation

petebacondarwin commented Mar 1, 2021

petebacondarwin Mar 2, 2021

Choose a reason for hiding this comment

JoostK left a comment

Choose a reason for hiding this comment

AndrewKushnir commented Mar 3, 2021

mhevery left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Apr 4, 2021