Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contributors guide to aio #41061

Closed
wants to merge 1 commit into from
Closed

docs: add contributors guide to aio #41061

wants to merge 1 commit into from

Conversation

aikithoughts
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@aikithoughts aikithoughts marked this pull request as draft March 3, 2021 00:08
@mary-poppins
Copy link

You can preview 6be5190 at https://pr41061-6be5190.ngbuilds.io/.

@ngbot ngbot bot added this to the Backlog milestone Mar 3, 2021
@mary-poppins
Copy link

You can preview dfd6e92 at https://pr41061-dfd6e92.ngbuilds.io/.

kapunahelewong
kapunahelewong reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

aio/content/navigation.json Outdated Show resolved Hide resolved
aio/content/guide/reviewing-content.md Outdated Show resolved Hide resolved
aio/content/guide/reviewing-content.md Outdated Show resolved Hide resolved
aio/content/guide/reviewing-content.md Outdated Show resolved Hide resolved
aio/content/guide/updating-content-github-ui.md Outdated Show resolved Hide resolved
aio/content/guide/updating-search-keywords.md Outdated
Comment on lines 30 to 34
<code-example lanugage="javascript">

{@searchKeywords route router routing navigation}

</code-example>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is showing up as missing in the preview... not sure how to fix this one...
Maybe try <code> around line 32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use {@searchKeywords} in the text, because the system thinks it's an actual tag. I couldn't figure out a way to fix that, so I did this:

{@searchKeywords}

aio/content/guide/updating-search-keywords.md Outdated Show resolved Hide resolved
aio/content/guide/updating-search-keywords.md Outdated Show resolved Hide resolved
kapunahelewong
kapunahelewong reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed a small thing after submitting my earlier review!

aio/content/guide/contributors-guide-overview.md Outdated Show resolved Hide resolved
aio/content/guide/contributors-guide-overview.md Outdated Show resolved Hide resolved
aio/content/guide/contributors-guide-overview.md Outdated Show resolved Hide resolved
aio/content/guide/contributors-guide-overview.md Outdated Show resolved Hide resolved
@aikithoughts aikithoughts marked this pull request as ready for review March 8, 2021 23:41
@mary-poppins
Copy link

You can preview 4f6b7e7 at https://pr41061-4f6b7e7.ngbuilds.io/.

kapunahelewong
kapunahelewong approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Reviewed-for: global-docs-approvers

josephperrott
josephperrott requested changes Mar 9, 2021
View reviewed changes
aio/content/guide/contributors-guide-overview.md Outdated Show resolved Hide resolved
aio/content/guide/reviewing-content.md Outdated Show resolved Hide resolved
aio/content/guide/updating-content-github-ui.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 5a73e63 at https://pr41061-5a73e63.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2d8cc6b at https://pr41061-2d8cc6b.ngbuilds.io/.

josephperrott
josephperrott approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just one spacing nit.

aio/content/guide/contributors-guide-overview.md Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 2cd17a4 at https://pr41061-2cd17a4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 628fa64 at https://pr41061-628fa64.ngbuilds.io/.

@yallen011
Copy link
Contributor

I can help review/test this PR @aikidave

@aikithoughts aikithoughts added the target: patch This PR is targeted for the next patch release label Mar 15, 2021
@mary-poppins
Copy link

You can preview e2670c4 at https://pr41061-e2670c4.ngbuilds.io/.

@aikithoughts aikithoughts removed the request for review from TeriGlover March 15, 2021 19:06
@aikithoughts aikithoughts added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2021
jessicajaniuk pushed a commit that referenced this pull request Mar 15, 2021
@thePunderWoman
docs: add contributors guide to aio (#41061)
bec919a 
PR Close #41061
gkalpak added a commit to gkalpak/angular that referenced this pull request Mar 17, 2021
@gkalpak
fix(docs-infra): add updating-content-github-ui guide to the sidenav
c52f814 
It seems that the `updating-content-github-ui` guide was accidentally
omitted from the sidenav in angular#41061.

This commit adds the guide to the sidenav.
gkalpak added a commit to gkalpak/angular that referenced this pull request Mar 17, 2021
@gkalpak
fix(docs-infra): add updating-content-github-ui guide to the sidenav
099dcda 
It seems that the `updating-content-github-ui` guide was accidentally
omitted from the sidenav in angular#41061.

This commit adds the guide to the sidenav.
@gkalpak gkalpak mentioned this pull request Mar 17, 2021
Closed
alxhub pushed a commit that referenced this pull request Apr 1, 2021
@gkalpak @alxhub
fix(docs-infra): add updating-content-github-ui guide to the sidenav (
bff7af4 
#41250)

It seems that the `updating-content-github-ui` guide was accidentally
omitted from the sidenav in #41061.

This commit adds the guide to the sidenav.

PR Close #41250
alxhub pushed a commit that referenced this pull request Apr 1, 2021
@gkalpak @alxhub
fix(docs-infra): add updating-content-github-ui guide to the sidenav (
51288e4 
#41250)

It seems that the `updating-content-github-ui` guide was accidentally
omitted from the sidenav in #41061.

This commit adds the guide to the sidenav.

PR Close #41250
TeriGlover pushed a commit to TeriGlover/angular that referenced this pull request Apr 5, 2021
@gkalpak @TeriGlover
fix(docs-infra): add updating-content-github-ui guide to the sidenav (
58ab641 
angular#41250)

It seems that the `updating-content-github-ui` guide was accidentally
omitted from the sidenav in angular#41061.

This commit adds the guide to the sidenav.

PR Close angular#41250
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgechev mgechev mgechev approved these changes

@kapunahelewong kapunahelewong kapunahelewong approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aikithoughts @mary-poppins @yallen011 @mgechev @kapunahelewong @josephperrott @zarend