fix(platform-browser): improve error message for missing animation tr…

[kirjs]

…igger

There are two reasons why this error can be called, but only one was covered before.

Fixes #15581

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• [n/a] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: #15581

What is the new behavior?

An example of a new error message is:

Found the synthetic property @myAnimation. Possible reasons:
  - "BrowserAnimationsModule" or "NoopAnimationsModule" are missing in your application.
  - There is no corresponding configuration for the animation named `@myAnimation` defined in the `animations` field of the `@Component` decorator (see https://angular.io/api/core/Component#animations).

Does this PR introduce a breaking change?

• Yes
• No

Other information

[kirjs]

I'm not sure if the animation message is relevant for the server code.
Should I roll that one back?

[jessicajaniuk]

I'm not sure if the animation message is relevant for the server code.
Should I roll that one back?

Leave it in. It's possible this error could happen server side depending on how the person configured things, and the NoopAnimationsModule would be what they should see there. So it's definitely helpful for debugging.

[jessicajaniuk]

LGTM 🍪

Thank you!

[AndrewKushnir]

@kirjs thanks for improving the error message 👍

I've left a few comments, could you please have a look when you get a chance?

[kirjs]

Addressed the feedback PTAL

[AndrewKushnir]

Thanks for addressing the feedback @kirjs 👍

I've left 1 minor comment, please have a look when you get a chance.

[AndrewKushnir]

Thanks for updating this PR @kirjs. It looks there is a couple more places where we can replace double quotes with backticks (for consistency). Could you please have a look at the comments when you get a chance? Thank you.

[AndrewKushnir]

@kirjs there are some lint warning as well, caused by the commit messages not being compliant with the format (the scope is missing, i.e. fix(...): part). Could you plz squash all commits into one once the feedback is addressed?

[petebacondarwin]

@google I consent

[petebacondarwin]

I have rebased and fixed up the requested changes.

[alan-agius4]

LGTM for platform-server

[AndrewKushnir]

Presubmit.

[AndrewKushnir]

@petebacondarwin thanks for pushing updates! I've started a new presubmit and will add the PR to the merge queue once presubmit is completed. Thank you.

[jessicajaniuk]

Ignore the closed message. This PR has been merged through tooling.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}