fix(WebWorker): Don't send messages when the buffer is empty #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jteplitz
added
action: review
| @@ -46,8 +46,10 @@ abstract class GenericMessageBusSink implements MessageBusSink { | |||
| void attachToZone(NgZone zone) { | |||
| _zone = zone; | |||
| _zone.overrideOnEventDone(() { | |||
| sendMessages(_messageBuffer); | |||
| _messageBuffer.clear(); | |||
| if (_messageBuffer.length > 0) { | |||
There was a problem hiding this comment.
Should this check be in the sendMessages method?
There was a problem hiding this comment.
No because sendMessages is called whenever the there are messages to send. It's overridden by the specific message bus implementations, so it doesn't make sense to call it with an empty array.
yjbanov
added
pr_state: LGTM
and removed
action: review
|
@yjbanov ping? |
|
Will pick up web worker stuff once we're done with pre-compilation. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.