feat(compiler): support nullish coalescing in templates #41437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
36528/nullish-coalescing
branch
from
68a9ed7
to
20ba227
Compare
crisbeto
added
action: review
alxhub
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Looks great, thanks @crisbeto 👍
I've started a presubmit to see if there are some cases that may require additional attention and will let you know.
...iance/test_cases/r3_view_compiler/nullish_coalescing/nullish_coalescing_property_template.js
Show resolved
Hide resolved
AndrewKushnir
added
action: presubmit
|
Quick update: presubmit looks good, I will also run a global one (TGP) tonight and will keep this thread updated. Thank you. |
AndrewKushnir
added
feature
|
FYI, global presubmit was successful as well, so I'm removing the "presubmit" label, which makes this PR fully ready for merge! |
Adds support for nullish coalescing expressions inside of Angular templates (e.g. `{{ a ?? b ?? c}}`).
Fixes angular#36528.
crisbeto
force-pushed
the
36528/nullish-coalescing
branch
from
20ba227
to
c117c0d
Compare
|
I've rebased and pushed another commit with more tests for host bindings. |
crisbeto
force-pushed
the
36528/nullish-coalescing
branch
from
c117c0d
to
0cf599a
Compare
crisbeto
force-pushed
the
36528/nullish-coalescing
branch
from
0cf599a
to
67f4d57
Compare
AndrewKushnir
approved these changes
Apr 7, 2021
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Apr 11, 2021
… nullish coalescing This is follow-up from angular#41437 and it reduces the amount of code we generate for safe property accesses (`a?.b`) and nullish coalescing (`a ?? b`) by: 1. Reusing variables in nested nullish coalescing expressions. 2. Not initializing temporary variables to `null`. The way our code is generated means that the value will always be overwritten before we compare against it so the initializer didn't really matter. Fixes angular#41491.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Apr 12, 2021
… nullish coalescing This is follow-up from angular#41437 and it reduces the amount of code we generate for safe property accesses (`a?.b`) and nullish coalescing (`a ?? b`) by: 1. Reusing variables in nested nullish coalescing expressions. 2. Not initializing temporary variables to `null`. The way our code is generated means that the value will always be overwritten before we compare against it so the initializer didn't really matter. Fixes angular#41491.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Apr 13, 2021
… nullish coalescing This is follow-up from angular#41437 and it reduces the amount of code we generate for safe property accesses (`a?.b`) and nullish coalescing (`a ?? b`) by: 1. Reusing variables in nested nullish coalescing expressions. 2. Not initializing temporary variables to `null`. The way our code is generated means that the value will always be overwritten before we compare against it so the initializer didn't really matter. Fixes angular#41491.
zarend
pushed a commit
that referenced
this pull request
Apr 14, 2021
… nullish coalescing (#41563) This is follow-up from #41437 and it reduces the amount of code we generate for safe property accesses (`a?.b`) and nullish coalescing (`a ?? b`) by: 1. Reusing variables in nested nullish coalescing expressions. 2. Not initializing temporary variables to `null`. The way our code is generated means that the value will always be overwritten before we compare against it so the initializer didn't really matter. Fixes #41491. PR Close #41563
zarend
pushed a commit
that referenced
this pull request
Apr 14, 2021
… nullish coalescing (#41563) This is follow-up from #41437 and it reduces the amount of code we generate for safe property accesses (`a?.b`) and nullish coalescing (`a ?? b`) by: 1. Reusing variables in nested nullish coalescing expressions. 2. Not initializing temporary variables to `null`. The way our code is generated means that the value will always be overwritten before we compare against it so the initializer didn't really matter. Fixes #41491. PR Close #41563
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for nullish coalescing expressions inside of Angular templates (e.g.
{{ a ?? b ?? c}}).Fixes #36528.