test(language-service): Add test to expose bug caused by source file change #41500

kyliau · 2021-04-08T00:04:00Z

This commit adds a test to expose the bug caused by source file change in
between typecheck programs.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

kyliau · 2021-04-08T00:06:52Z

packages/language-service/ivy/testing/src/project.ts

@@ -103,6 +103,7 @@ export class Project {
      // Mark the project as dirty because the act of opening a file may result in the version
      // changing since TypeScript will `switchToScriptVersionCache` when a file is opened.
      // Note that this emulates what we have to do in the server/extension as well.
+      // TODO: remove this once PR #41475 lands
      this.tsProject.markAsDirty();


Test will fail if this line is removed.

…change This commit adds a test to expose the bug caused by source file change in between typecheck programs.

…change (angular#41500) This commit adds a test to expose the bug caused by source file change in between typecheck programs. PR Close angular#41500

…g `$` This commit adds support for `$` in when selecting attributes. Resolves angular#41244. test(language-service): Add test to expose bug caused by source file change (angular#41500) This commit adds a test to expose the bug caused by source file change in between typecheck programs. PR Close angular#41500

…change (angular#41500) This commit adds a test to expose the bug caused by source file change in between typecheck programs. PR Close angular#41500

…g `$` This commit adds support for `$` in when selecting attributes. Resolves angular#41244. test(language-service): Add test to expose bug caused by source file change (angular#41500) This commit adds a test to expose the bug caused by source file change in between typecheck programs. PR Close angular#41500

…change (angular#41500) This commit adds a test to expose the bug caused by source file change in between typecheck programs. PR Close angular#41500

…g `$` This commit adds support for `$` in when selecting attributes. Resolves angular#41244. test(language-service): Add test to expose bug caused by source file change (angular#41500) This commit adds a test to expose the bug caused by source file change in between typecheck programs. PR Close angular#41500

…g `$` (#41567) This commit adds support for `$` in when selecting attributes. Resolves #41244. test(language-service): Add test to expose bug caused by source file change (#41500) This commit adds a test to expose the bug caused by source file change in between typecheck programs. PR Close #41500 PR Close #41567

angular-automatic-lock-bot · 2021-05-17T16:08:39Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

kyliau added area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Apr 8, 2021

kyliau requested review from atscott and alxhub April 8, 2021 00:04

ngbot bot modified the milestone: Backlog Apr 8, 2021

google-cla bot added the cla: yes label Apr 8, 2021

kyliau commented Apr 8, 2021

View reviewed changes

test(language-service): Add test to expose bug caused by source file …

432655f

…change This commit adds a test to expose the bug caused by source file change in between typecheck programs.

kyliau force-pushed the source-file-change branch from 74c3865 to 432655f Compare April 8, 2021 20:41

atscott approved these changes Apr 9, 2021

View reviewed changes

kyliau added the action: merge The PR is ready for merge by the caretaker label Apr 9, 2021

kyliau removed the request for review from alxhub April 9, 2021 18:16

zarend approved these changes Apr 9, 2021

View reviewed changes

zarend closed this in 61bfa3d Apr 9, 2021

This was referenced Apr 10, 2021

Choose two branches to see what’s changed or to start a new pull request GulajavaMinistudio/angular#439

Merged

Choose two branches to see what’s changed or to start a new pull request TypescriptID/angular#634

Merged

kyliau mentioned this pull request Apr 13, 2021

fix: mark project as dirty after a TS file is opened angular/vscode-ng-language-service#1264

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators May 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(language-service): Add test to expose bug caused by source file change #41500

test(language-service): Add test to expose bug caused by source file change #41500

kyliau commented Apr 8, 2021

kyliau Apr 8, 2021

angular-automatic-lock-bot bot commented May 17, 2021

test(language-service): Add test to expose bug caused by source file change #41500

test(language-service): Add test to expose bug caused by source file change #41500

Conversation

kyliau commented Apr 8, 2021

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

kyliau Apr 8, 2021

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented May 17, 2021