Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Angular 12 support information #42124

Closed
wants to merge 1 commit into from
Closed

docs: add Angular 12 support information #42124

wants to merge 1 commit into from

Conversation

iRealNirmal
Copy link
Contributor

Added angular 12 suppport information in release document

Closes #42111

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Document is missing angular 12 support information

Issue Number: #42111

What is the new behavior?

Angular 12 support dates are added

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label May 17, 2021
@pullapprove pullapprove bot requested a review from IgorMinar May 17, 2021 10:34
petebacondarwin
petebacondarwin approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Revewied-for: global-docs-approvers

@petebacondarwin petebacondarwin added comp: docs target: patch This PR is targeted for the next patch release labels May 17, 2021
@ngbot ngbot bot added this to the Backlog milestone May 17, 2021
@petebacondarwin petebacondarwin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 17, 2021
@iRealNirmal
docs: add Angular 12 support information
5290f4b 
Added angular 12 suppport information in release document

Closes angular#42111
Splaktar
Splaktar approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@Splaktar Splaktar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

I triggered a rerun of the failing legacy-unit-tests-saucelabs test that timed out.

gkalpak
gkalpak approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @iRealNirmal ✨

Reviewed-for: global-docs-approvers

@gkalpak gkalpak removed the request for review from IgorMinar May 21, 2021 06:05
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 21, 2021
@gkalpak gkalpak mentioned this pull request May 21, 2021
Closed
zarend pushed a commit that referenced this pull request May 21, 2021
@iRealNirmal @zarend
docs: add Angular 12 support information (#42124)
f4cf00d 
Added angular 12 suppport information in release document

Closes #42111

PR Close #42124
@zarend zarend closed this in 34cd4dc May 21, 2021
iRealNirmal added a commit to iRealNirmal/angular that referenced this pull request Jun 4, 2021
@iRealNirmal
docs: add Angular 12 support information (angular#42124)
2ce34ba 
Added angular 12 suppport information in release document

Closes angular#42111

PR Close angular#42124
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@Splaktar Splaktar Splaktar approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Angular 12 support dates missing on angular.io
5 participants
@iRealNirmal @petebacondarwin @JoostK @Splaktar @gkalpak