Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): implement ContentChildren and ViewChildren #4237

Closed
wants to merge 2 commits into from
Closed

feat(query): implement ContentChildren and ViewChildren #4237

wants to merge 2 commits into from

Conversation

vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Sep 17, 2015

@mhever @rkirov Could either of you review this guy?

@vsavkin vsavkin added action: review The PR is still awaiting reviews from at least one requested reviewer effort2: days labels Sep 17, 2015
rkirov
rkirov reviewed Sep 17, 2015
View reviewed changes
modules/angular2/src/core/compiler/directive_resolver.ts
@@ -99,6 +112,7 @@ export class DirectiveResolver {
exportAs: dm.exportAs,
moduleId: dm.moduleId,
compileChildren: dm.compileChildren,
queries: queries,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we consider having queries and viewqueries separately?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, there is no value is separating them.

@0x-r4bbit 0x-r4bbit mentioned this pull request Sep 17, 2015
Closed
rkirov
rkirov reviewed Sep 17, 2015
View reviewed changes
modules/angular2/src/core/compiler/element_injector.ts

private _createQueryRef(query: QueryMetadata): void {
private _createQueryRef(dirIndex: number, setter: Function, query: QueryMetadata): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace Function event with (any, any) => any it will still provide a bit more typechecking, i.e. calling it with wrong number of args.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

@rkirov rkirov added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2015
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2015
@mary-poppins
Copy link

Merging PR #4237 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4237.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 18, 2015
@rkirov rkirov mentioned this pull request Sep 18, 2015
Closed
12 tasks
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 20, 2015
@mary-poppins
Copy link

Merging PR #4237 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4237.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 20, 2015
@vsavkin vsavkin closed this in 2e9de0b Sep 20, 2015
robwormald pushed a commit to robwormald/angular that referenced this pull request Sep 25, 2015
@vsavkin @robwormald
feat(core): add sugar to use ContentChildren and ViewChildren as prop…
f09e539 
… decorators

Closes angular#4237
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rkirov rkirov

Labels
cla: yes effort2: days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vsavkin @mary-poppins @rkirov @tommyminds @0x-r4bbit @googlebot