docs(forms): make the reactive forms guide specify more clearly discuss mixing HTML5 native validators with Angular forms. #42377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylhunn
added
target: patch
|
|
dylhunn
force-pushed
the
form-docs
branch
2 times, most recently
from
137f597
to
336327f
Compare
dylhunn
force-pushed
the
form-docs
branch
3 times, most recently
from
77cc58e
to
56701be
Compare
dylhunn
force-pushed
the
form-docs
branch
2 times, most recently
from
f60eba8
to
b028ca0
Compare
|
You can preview 336327f at https://pr42377-336327f.ngbuilds.io/. |
…t happens when mixing HTML5 native validators with Angular forms. Previously, the docs didn't say anything about the fact that the `novalidate` attribute is added to the enclosing form, or how to override that behavior. I have added a couple lines in the appropriate spot clarifying this issue.
|
You can preview 6c87908 at https://pr42377-6c87908.ngbuilds.io/. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 1, 2021
…t happens when mixing HTML5 native validators with Angular forms. (#42377) Previously, the docs didn't say anything about the fact that the `novalidate` attribute is added to the enclosing form, or how to override that behavior. I have added a couple lines in the appropriate spot clarifying this issue. PR Close #42377
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this pull request
Jun 2, 2021
…t happens when mixing HTML5 native validators with Angular forms. (angular#42377) Previously, the docs didn't say anything about the fact that the `novalidate` attribute is added to the enclosing form, or how to override that behavior. I have added a couple lines in the appropriate spot clarifying this issue. PR Close angular#42377
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a couple lines in the appropriate spot clarifying this issue.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Reactive forms allow the use of HTML5 native validators, but there is a gotcha:
novalidateis added to the enclosing form, disabling the native HTML5 behavior. Previously, the docs didn't say anything about that, or how to override that behavior.Issue Number: 39549
What is the new behavior?
The docs now specify that
novalidateis added to the enclosing form, and native validation can be re-enabled with thengNativeValidatedirective.Does this PR introduce a breaking change?
Other information
Closes #39549