Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): describe interactions between view-encapsulated components #42397

Closed

Conversation

petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented May 27, 2021

This commit adds information to the view encapsulation guide that
describes the styling interactions between components that use differing
view encapsulation modes.

Closes #40715

Here is a link to the main section of the docs that changed: https://pr42397-a0dcc27.ngbuilds.io/guide/view-encapsulation#mixing-encapsulation-modes

@petebacondarwin petebacondarwin added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release core: CSS encapsulation labels May 27, 2021
@ngbot ngbot bot modified the milestone: Backlog May 27, 2021
@google-cla google-cla bot added the cla: yes label May 27, 2021
@pullapprove pullapprove bot requested a review from AndrewKushnir May 27, 2021 20:32
@petebacondarwin petebacondarwin force-pushed the docs-view-encapsulation branch 2 times, most recently from 49c45f1 to a0dcc27 Compare May 27, 2021 20:38
@mary-poppins
Copy link

You can preview a0dcc27 at https://pr42397-a0dcc27.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9265450 at https://pr42397-9265450.ngbuilds.io/.

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petebacondarwin this is awesome, thanks for putting this together! 👍

I've left a couple really minor comments and I think it'd be great if @jelbourn can have a look at these changes too to see if there is any additional feedback/improvements.

aio/content/guide/view-encapsulation.md Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TeriGlover TeriGlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing review completed, left a few suggestions. Otherwise, LGTM.

aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
@petebacondarwin
Copy link
Member Author

petebacondarwin commented May 28, 2021

I have added two fixup commits:

  • The first deals directly with the feedback from @AndrewKushnir and @TeriGlover (thanks!).
  • The second is a bit of a rewrite because I realised that the examples did not cover very well the fact that that no-encapsulation styles are still available within shadow-dom encapsulation components.

PTAL

@mary-poppins
Copy link

You can preview 0cb5e7b at https://pr42397-0cb5e7b.ngbuilds.io/.

Copy link
Contributor

@TeriGlover TeriGlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, otherwise LGTM.

aio/content/guide/view-encapsulation.md Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
@TeriGlover
Copy link
Contributor

TeriGlover commented May 28, 2021 via email

@mary-poppins
Copy link

You can preview 3f065f3 at https://pr42397-3f065f3.ngbuilds.io/.

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks Pete 👍

aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
aio/content/guide/view-encapsulation.md Outdated Show resolved Hide resolved
@petebacondarwin
Copy link
Member Author

@jelbourn can you PTAL? Thanks

@mary-poppins
Copy link

You can preview da87925 at https://pr42397-da87925.ngbuilds.io/.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 8, 2021
jessicajaniuk pushed a commit that referenced this pull request Jun 8, 2021
#42397)

This commit adds information to the view encapsulation guide that
describes the styling interactions between components that use differing
view encapsulation modes.

Closes #40715

PR Close #42397
@petebacondarwin petebacondarwin deleted the docs-view-encapsulation branch June 17, 2021 08:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 18, 2021
TeriGlover pushed a commit to TeriGlover/angular that referenced this pull request Jul 21, 2021
angular#42397)

This commit adds information to the view encapsulation guide that
describes the styling interactions between components that use differing
view encapsulation modes.

Closes angular#40715

PR Close angular#42397
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: core Issues related to the framework runtime cla: yes core: CSS encapsulation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient docs for interaction when mixing view encapsulation modes
6 participants