-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(core): describe interactions between view-encapsulated components #42397
docs(core): describe interactions between view-encapsulated components #42397
Conversation
49c45f1
to
a0dcc27
Compare
You can preview a0dcc27 at https://pr42397-a0dcc27.ngbuilds.io/. |
a0dcc27
to
9265450
Compare
You can preview 9265450 at https://pr42397-9265450.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petebacondarwin this is awesome, thanks for putting this together! 👍
I've left a couple really minor comments and I think it'd be great if @jelbourn can have a look at these changes too to see if there is any additional feedback/improvements.
aio/content/examples/view-encapsulation/e2e/src/app.e2e-spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editing review completed, left a few suggestions. Otherwise, LGTM.
aio/content/examples/view-encapsulation/e2e/src/app.e2e-spec.ts
Outdated
Show resolved
Hide resolved
9265450
to
60bb3c7
Compare
I have added two fixup commits:
PTAL |
60bb3c7
to
0cb5e7b
Compare
You can preview 0cb5e7b at https://pr42397-0cb5e7b.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, otherwise LGTM.
Review complete with a few suggestions, otherwise LGTM.
…On Fri, May 28, 2021 at 8:02 AM Mary Poppins ***@***.***> wrote:
You can preview 0cb5e7b
<0cb5e7b>
at https://pr42397-0cb5e7b.ngbuilds.io/.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42397 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR4DPGWGGOSCC2MDJPJ5STTTP6V7LANCNFSM45VBIU4A>
.
--
*--Teri Glover--*
*Technical Editor*
|
You can preview 3f065f3 at https://pr42397-3f065f3.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks Pete 👍
This commit adds information to the view encapsulation guide that describes the styling interactions between components that use differing view encapsulation modes. Closes angular#40715
3f065f3
to
da87925
Compare
@jelbourn can you PTAL? Thanks |
You can preview da87925 at https://pr42397-da87925.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
angular#42397) This commit adds information to the view encapsulation guide that describes the styling interactions between components that use differing view encapsulation modes. Closes angular#40715 PR Close angular#42397
This commit adds information to the view encapsulation guide that
describes the styling interactions between components that use differing
view encapsulation modes.
Closes #40715
Here is a link to the main section of the docs that changed: https://pr42397-a0dcc27.ngbuilds.io/guide/view-encapsulation#mixing-encapsulation-modes