Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix ngProjectAs selector in example #42523

Closed
wants to merge 1 commit into from
Closed

docs: fix ngProjectAs selector in example #42523

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

Fixes #42522

@petebacondarwin petebacondarwin added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview target: patch This PR is targeted for the next patch release labels Jun 9, 2021
@ngbot ngbot bot modified the milestone: Backlog Jun 9, 2021
@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@pullapprove pullapprove bot requested a review from AndrewKushnir June 9, 2021 06:11
@mary-poppins
Copy link

You can preview c567fa4 at https://pr42523-c567fa4.ngbuilds.io/.

@petebacondarwin petebacondarwin force-pushed the docs-content-projection-issue-42522 branch from c567fa4 to 802cf7e Compare June 9, 2021 06:23
@mary-poppins
Copy link

You can preview 802cf7e at https://pr42523-802cf7e.ngbuilds.io/.

AndrewKushnir
AndrewKushnir approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 9, 2021
@alxhub alxhub closed this in e36c5b4 Jun 9, 2021
alxhub pushed a commit that referenced this pull request Jun 9, 2021
@petebacondarwin @alxhub
docs: fix ngProjectAs selector in example (#42523)
6639960 
Fixes #42522

PR Close #42523
@petebacondarwin petebacondarwin deleted the docs-content-projection-issue-42522 branch June 17, 2021 08:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Components/Content projection: Wrong selector used in the live example for the usage of "ngProjectAs"
3 participants
@petebacondarwin @mary-poppins @AndrewKushnir