build: test angular.io/docs examples against RxJS v7 #42660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
You can preview b18dd9d at https://pr42660-b18dd9d.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
|
You can preview 4e4d7ca at https://pr42660-4e4d7ca.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
|
You can preview 1188781 at https://pr42660-1188781.ngbuilds.io/. |
jessicajaniuk
added
the
area: build & ci
|
You can preview 6793089 at https://pr42660-6793089.ngbuilds.io/. |
gkalpak
added
action: review
|
You can preview cf69034 at https://pr42660-cf69034.ngbuilds.io/. |
crisbeto
approved these changes
Jun 27, 2021
This commit adds support for excluding certain docs examples from the command used to run tests. This is useful to run extra tests on CI that might not be compatible with all examples (for example, run tests with different versions of a dependency). In a subsequent commit, this will be used to run tests against RxJS v7 as a quick way to catch potential regressions.
…th RxJS v7 This commit applies the necessary changes to make angular.io and (most) docs examples compatible with both RxJS v6 and v7. It also adds new steps to relevant CI jobs to test angular.io and docs examples against RxJS v7 as well (to catch potential regressions). NOTE: Some of the docs examples are not compatible with RxJS v7 and are therefore excluded from the tests. The SystemJS-based ngUpgrade examples in particular are excluded, since they require a different SystemJS configs to run against RxJS v6 and v7 and the extra complexity of managing that is not worth it for the 4 affected examples.
|
You can preview abb1cd0 at https://pr42660-abb1cd0.ngbuilds.io/. |
gkalpak
added
action: merge
|
Marking this for merging. |
gkalpak
added
comp: docs-infra
action: review
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 29, 2021
…42660) This commit adds support for excluding certain docs examples from the command used to run tests. This is useful to run extra tests on CI that might not be compatible with all examples (for example, run tests with different versions of a dependency). In a subsequent commit, this will be used to run tests against RxJS v7 as a quick way to catch potential regressions. PR Close #42660
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 29, 2021
…th RxJS v7 (#42660) This commit applies the necessary changes to make angular.io and (most) docs examples compatible with both RxJS v6 and v7. It also adds new steps to relevant CI jobs to test angular.io and docs examples against RxJS v7 as well (to catch potential regressions). NOTE: Some of the docs examples are not compatible with RxJS v7 and are therefore excluded from the tests. The SystemJS-based ngUpgrade examples in particular are excluded, since they require a different SystemJS configs to run against RxJS v6 and v7 and the extra complexity of managing that is not worth it for the 4 affected examples. PR Close #42660
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 29, 2021
…th RxJS v7 (#42660) This commit applies the necessary changes to make angular.io and (most) docs examples compatible with both RxJS v6 and v7. It also adds new steps to relevant CI jobs to test angular.io and docs examples against RxJS v7 as well (to catch potential regressions). NOTE: Some of the docs examples are not compatible with RxJS v7 and are therefore excluded from the tests. The SystemJS-based ngUpgrade examples in particular are excluded, since they require a different SystemJS configs to run against RxJS v6 and v7 and the extra complexity of managing that is not worth it for the 4 affected examples. PR Close #42660
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jul 29, 2021
We can't update the framework to rxjs7 until version 13, because it contains breaking changes, but we can allow users to opt into it since all of our code should be compatible. These changes expand the allowed version range of rxjs and add an integration test to verify that we don't get compilation errors. Note that we also have a test that runs the AIO examples against rxjs 7 already (angular#42660). Fixes angular#41897.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jul 29, 2021
We can't update the framework to rxjs7 until version 13, because it contains breaking changes, but we can allow users to opt into it since all of our code should be compatible. These changes expand the allowed version range of rxjs and add an integration test to verify that we don't get compilation errors. Note that we also have a test that runs the AIO examples against rxjs 7 already (angular#42660). Fixes angular#41897.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend PR #41793 to run angular.io and docs-examples tests against RxJS v7 on CI (as a quick way to guard against potential regressions).