Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(compiler): support i18n interpolated only attribute bindings (#43815)" #43882

Closed
wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This reverts commit bba0a87.

The reason for rollback: this change is breaking some targets in Google's codebase when there is no attribute value is displayed (attr.aria-label) when translated.

…ngs (angular#43815)"

This reverts commit bba0a87.

The reason for rollback: this change is breaking some targets in Google's codebase when there is no attribute value is displayed (attr.aria-label) when translated.
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: i18n target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 18, 2021
@ngbot ngbot bot modified the milestone: Backlog Oct 18, 2021
@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Oct 18, 2021

Merge-assistance: this is a rollback of a change that I've reviewed before (no extra reviews for the rollback are needed).

@AndrewKushnir
Copy link
Contributor Author

This PR was merged into the repository by commit 60f3b33.

AndrewKushnir added a commit that referenced this pull request Oct 18, 2021
…ngs (#43815)" (#43882)

This reverts commit bba0a87.

The reason for rollback: this change is breaking some targets in Google's codebase when there is no attribute value is displayed (attr.aria-label) when translated.

PR Close #43882
AndrewKushnir added a commit that referenced this pull request Oct 18, 2021
…ngs (#43815)" (#43882)

This reverts commit bba0a87.

The reason for rollback: this change is breaking some targets in Google's codebase when there is no attribute value is displayed (attr.aria-label) when translated.

PR Close #43882
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2021
Serginho pushed a commit to TuLotero/angular that referenced this pull request Jan 20, 2022
…ngs (angular#43815)" (angular#43882)

This reverts commit bba0a87.

The reason for rollback: this change is breaking some targets in Google's codebase when there is no attribute value is displayed (attr.aria-label) when translated.

PR Close angular#43882
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: i18n cla: yes PullApprove: disable target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant