Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(buildElementPropertyBindings): improve error message when binding to an known property #4396

Closed

Conversation

nosachamos
Copy link

Currently we alert the user that no such property exists for the given element,
but we could indicate that if user is attempting to bind to an attribute then
the attr. prefix should be used.

Part of #4385

…pting to bind to an known property

Currently we alert the user that no such property exists for the given element,
but we could indicate that if user is attempting to bind to an attribute then
the attr. prefix should be used.

Part of angular#4385
@mgechev
Copy link
Member

mgechev commented Sep 28, 2015

I guess your VS Code have removed .settings/settings.json, probably you should keep it.

@todoubaba
Copy link
Contributor

VS Code 0.8.0 renames .settings. to .vscode.

@nosachamos
Copy link
Author

@mgechev is it cool to keep the file's new location (under the .vscode folder) since I think most folks will be migrating to VS Code 0.8.0 or you guys prefer me to move it back to the root and update?

@nosachamos
Copy link
Author

BTW, this is on me now to fix the clang formatting issue. Will do later tonight and update.

@pkozlowski-opensource
Copy link
Member

@nosachamos I appreciate that you've bumped into this error while trying to bind to an attribute, but there are other cases: property not found, misspelled property etc. So I'm not sure how I feel about adding this attribute-specific hint here...

@nosachamos
Copy link
Author

@pkozlowski-opensource I see, you have a point for sure. A hint here would have saved me some time since this is a special syntax one must learn in order to bind to attributes, but I suppose if the docs were completed I could have easily found that info over there. So not much of a benefit for GA.

@mhevery
Copy link
Contributor

mhevery commented Oct 5, 2015

Closing, as pointed out here: #4396 (comment) Reopen new one if you have a better solution.

@mhevery mhevery closed this Oct 5, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants