Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update availability for pullapprove #44312

Closed
wants to merge 2 commits into from
Closed

ci: Update availability for pullapprove #44312

wants to merge 2 commits into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Nov 30, 2021

Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/

@atscott atscott added the target: patch This PR is targeted for the next patch release label Nov 30, 2021
@google-cla google-cla bot added the cla: yes label Nov 30, 2021
josephperrott
josephperrott approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Nov 30, 2021
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 30, 2021
@dylhunn dylhunn added the area: build & ci Related the build and CI infrastructure of the project label Nov 30, 2021
@ngbot ngbot bot added this to the Backlog milestone Nov 30, 2021
@AndrewKushnir
Copy link
Contributor

@atscott it looks like there is a merge conflict (the lint failure looks legit as well), so I'm adding the "cleanup' label for now. Could you please rebase this PR when you get a chance?

@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 30, 2021
@dylhunn
Copy link
Contributor

dylhunn commented Nov 30, 2021

This PR was merged into the repository by commit 5124c06.

@dylhunn dylhunn closed this in 5124c06 Nov 30, 2021
dylhunn pushed a commit that referenced this pull request Nov 30, 2021
@atscott @dylhunn
ci: Update availability for pullapprove (#44312)
264aad9 
Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/

PR Close #44312
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
@atscott @dimakuba
ci: Update availability for pullapprove (angular#44312)
bd10ad3 
Follows the v3 pullapprove docs here: https://docs.pullapprove.com/config/availability/

PR Close angular#44312
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atscott @AndrewKushnir @dylhunn @josephperrott