Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(animations): add links to state() references #44376

Closed
wants to merge 2 commits into from
Closed

docs(animations): add links to state() references #44376

wants to merge 2 commits into from

Conversation

dario-piotrowicz
Copy link
Contributor

the keyword 'state' is included in the ignoredWords set that prevents
certain words to be autolinked, this causes the animations' state
function not to be automatically linked, so manually link those
references to the state api docs

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Issue

Issue Number: N/A

Does this PR introduce a breaking change?

  • Yes
  • No

@google-cla google-cla bot added the cla: yes label Dec 4, 2021
@pullapprove pullapprove bot requested review from alxhub and crisbeto December 4, 2021 13:53
gkalpak
gkalpak approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @dario-piotrowicz!

Reviewed-for: global-docs-approvers

@gkalpak gkalpak added area: animations comp: docs target: patch This PR is targeted for the next patch release labels Dec 5, 2021
@ngbot ngbot bot modified the milestone: Backlog Dec 5, 2021
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 5, 2021
@gkalpak
Copy link
Member

gkalpak commented Dec 5, 2021

merge-assistance: These are docs-only changes and shouldn't need a presubmit.

@dario-piotrowicz
Copy link
Contributor Author

@gkalpak sorry I just noticed I missed some instances of state 🙇 , just added them as a fixup commit, I hope it's fine 🙂

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 7, 2021
@mary-poppins
Copy link

You can preview df90a24 at https://pr44376-df90a24.ngbuilds.io/.
You can preview 30b9ca6 at https://pr44376-30b9ca6.ngbuilds.io/.
You can preview a6a1f75 at https://pr44376-a6a1f75.ngbuilds.io/.

gkalpak
gkalpak requested changes Dec 9, 2021
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making the changes 👍

packages/animations/src/animation_metadata.ts Outdated Show resolved Hide resolved
aio/src/styles/2-modules/code/_code.scss Show resolved Hide resolved
aio/content/guide/animations.md Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 7630a1c at https://pr44376-7630a1c.ngbuilds.io/.

@dario-piotrowicz
docs(animations): add links to state() references
1b3c636 
the keyword 'state' is included in the `ignoredWords` set that prevents
certain words to be autolinked, this causes the animations' state
function not to be automatically linked, so manually link those
references to the state api docs
@dario-piotrowicz
fix(docs-infra): adjust code link styling height
07f3ac0 
the height of code links (anchors inside code tags or
code tags inside anchors) is inconsistent, fix such
issue by also making sure that code links to external
resources do not get wrongly styled
@mary-poppins
Copy link

You can preview 07f3ac0 at https://pr44376-07f3ac0.ngbuilds.io/.

gkalpak
gkalpak approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @dario-piotrowicz 💯

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 15, 2021
@gkalpak
Copy link
Member

gkalpak commented Dec 15, 2021

merge-assistance: This is a docs-only change and should not need a g3 presubmit.

@dario-piotrowicz dario-piotrowicz mentioned this pull request Dec 19, 2021
Closed
14 tasks
@dylhunn
Copy link
Contributor

dylhunn commented Jan 4, 2022

This PR was merged into the repository by commit a864d1c.

@dylhunn dylhunn closed this in 7663dd0 Jan 4, 2022
dylhunn pushed a commit that referenced this pull request Jan 4, 2022
@dario-piotrowicz @dylhunn
fix(docs-infra): adjust code link styling height (#44376)
a864d1c 
the height of code links (anchors inside code tags or
code tags inside anchors) is inconsistent, fix such
issue by also making sure that code links to external
resources do not get wrongly styled

PR Close #44376
dylhunn pushed a commit that referenced this pull request Jan 4, 2022
@dario-piotrowicz @dylhunn
docs(animations): add links to state() references (#44376)
55209e5 
the keyword 'state' is included in the `ignoredWords` set that prevents
certain words to be autolinked, this causes the animations' state
function not to be automatically linked, so manually link those
references to the state api docs

PR Close #44376
dylhunn pushed a commit that referenced this pull request Jan 4, 2022
@dario-piotrowicz @dylhunn
fix(docs-infra): adjust code link styling height (#44376)
25aef62 
the height of code links (anchors inside code tags or
code tags inside anchors) is inconsistent, fix such
issue by also making sure that code links to external
resources do not get wrongly styled

PR Close #44376
atscott pushed a commit to atscott/angular that referenced this pull request Jan 4, 2022
@dario-piotrowicz @atscott
fix(docs-infra): adjust code link styling height (angular#44376)
ee3700f 
the height of code links (anchors inside code tags or
code tags inside anchors) is inconsistent, fix such
issue by also making sure that code links to external
resources do not get wrongly styled

PR Close angular#44376
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: animations cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dario-piotrowicz @gkalpak @mary-poppins @dylhunn