New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(animations): improve animation transition api docs #44396
docs(animations): improve animation transition api docs #44396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dario-piotrowicz This looks really good. Can you add a couple of examples based on the comments I left? I think they'd be really helpful. Otherwise this looks great.
e7c49d0
to
38b43d4
Compare
@jessicajaniuk thanks a lot for the nice reviewing 馃槂 , I've added examples for the State Change Expressions please let me know what you think 馃檪 Also what do you think, should I also add an example for the function variant? I would and could be a nice addition, but I am afraid that it would look a bit weird/unclear there in the first list 馃 |
@dario-piotrowicz You could add just one example at the end of all of the examples and clarify in a comment that it shows what a function variant of these would look like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃崻
Once you add those last little changes, this looks great! Thanks for your work!
improve the transition api docs by removing unnecessary examplanations and examples also provide helpful information regarding entering and leaving elements (as part of angular#44253)
77a6e6b
to
97950ec
Compare
@jessicajaniuk I've added an example of the function variant at the end of the page, please have a look and let me know what you think 馃檪
I'm not sure I full understood this comment 馃槗 , are you suggesting to show the function variant for each single example I provided? I'm afraid that could be quite verbose and repetitive, wouldn't it? 馃槗 |
I think you've covered it. Thanks, @dario-piotrowicz. :) |
This PR was merged into the repository by commit 9249506. |
improve the transition api docs by removing unnecessary examplanations and examples also provide helpful information regarding entering and leaving elements (as part of angular#44253) PR Close angular#44396
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
improve the transition api docs by removing unnecessary examplanations
and examples
also provide helpful information regarding entering and leaving
elements (as part of #44253)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue
Relates to Issue #44253
Does this PR introduce a breaking change?
Other information
I started looking into these docs because as part of #44253 I wanted to add the information about entering and leaving elements, but I thought that the docs here were quite unorganised and confusing so I tried to clean them up
before there were information all over the place and many thing were repeated and/or not explained clearly in my opinion
I hope I did well, if you could please give this a preview you can see that in the way I've changed it, it is much leaner, clear and easy to follow (at least for me 馃槣)