Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update angular and dev-infra package while accounting for rule changes #44490

Closed
wants to merge 7 commits into from
Closed

build: update angular and dev-infra package while accounting for rule changes #44490

wants to merge 7 commits into from

Commits on Dec 16, 2021

  1. build: update angular 

    Updates Angular and the dev-infra package to the latest
version/build.
    @devversion
    devversion committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    0799a17 View commit details
    Browse the repository at this point in the history

  2. build: update symbol extractor to support IIFE bundles using arrow-fu… 

    …nctions

Updates the symbol extractor to support IIFE bundles using
arrow-functions instead of function declarations. This is in preparation
for running symbol extraction tests with the overhauled optimization
pipeline for Angular v13, relying on ESBuild internally.

Also removes rollup-specific code that does not seem to be relevant
anymore / rollup will be replaced anyway.
    @devversion
    devversion committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    73b7472 View commit details
    Browse the repository at this point in the history

  3. build: add postinstall script as runfile for yarn_install repositor… 

    …y rule

Adds the postinstall script as runfile for the `yarn_install`
repository rule, so that the dependencies are re-fetched when
the script changes.
    @devversion
    devversion committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    02d5d83 View commit details
    Browse the repository at this point in the history

  4. build: update postinstall script to account for local target referenc… 

    …es in dev-infra

We are in an inconvenient situation where the ng-dev package might rely
on packages from the Angular framework repository. Given that we install
this package in the framework repository, we need to update some
references through a postinstall.

This commit updates the patches to account for the latest changes in the
dev-infra package/repository.
    @devversion
    devversion committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    c02ee5d View commit details
    Browse the repository at this point in the history

  5. build: switch all instances from ng_rollup_bundle to app_bundle 

    The `ng_rollup_bundle` rule has been replaced with a new rule called
`app_bundle`. This rule replicates the Angular v13 optimization
pipeline in the CLI, so that we can get better benchmarking results.
Also the rule is much simpler to maintain as it relies on ESbuild.

The old `ng_rollup_bundle` rule did rely on e.g. build-optimizer that no
longer has an effect on v13 Angular packages, so technically size
tests/symbol tests were no longer as correct as they were before. This
commit fixes that.

A couple of different changes and their explanation:

* Language-service will no longer use the benchmark rule for creating
  its NPM bundles! It will use plain `rollup_bundle`. ESBuild would have
  been nice but the language-service relies on AMD that ESBuild cannot
  generate (yet?)

* Service-worker ngsw-worker.js file was generated using the benchmark
  bundle rule. This is wrong. We will use a simple ESbuild rule in the
  future. The output is more predictable that way, and we can have a
  clear use of the benchmark bundle rule..

* A couple of benchmarks in `modules/` had to be updated to use e.g.
  `initTableUtils` calls. This is done because with the new rule, all
  files except for the entry-point are considered side-effect free. The
  utilities for benchmarks relied on side-effects in some
  transitively-loaded file (bad practice anyway IMO). We are now
  initializing the utilities using a proper init function that is
  exported...
    @devversion
    devversion committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    25854fb View commit details
    Browse the repository at this point in the history

  6. build: update release config to reflect latest ng-dev config changes 

    The ng-dev release config changed its release configuration in order
to support experimental packages. This commit updates the FW release
config to work with the new config signature of ng-dev.

All of our peackages are non-experimental, so we do not specify
an explicit `experimental` property.
    @devversion
    devversion committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    29f1e85 View commit details
    Browse the repository at this point in the history

  7. test: update size goldens to reflect latest CLI devkit update 

    Updates the size goldens to the reflect the latest CLI devkit updates.
    @devversion
    devversion committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    127dafd View commit details
    Browse the repository at this point in the history