Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-service): revert the test files for Ivy #44528

Closed
wants to merge 1 commit into from
Closed

fix(language-service): revert the test files for Ivy #44528

wants to merge 1 commit into from

Conversation

ivanwonder
Copy link
Contributor

The completions_spec and definitions_spec is removed by accident
in bb9ff60

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alxhub December 18, 2021 01:31
@ivanwonder
Copy link
Contributor Author

#40300 (comment)

@atscott

@ivanwonder
fix(language-service): revert the test files for Ivy
0c181e8 
The `completions_spec` and `definitions_spec` is removed by accident
in [bb9ff60](angular@bb9ff60)
@atscott atscott removed the request for review from alxhub December 20, 2021 16:30
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 20, 2021
@dylhunn dylhunn added the area: language-service Issues related to Angular's VS Code language service label Jan 4, 2022
@ngbot ngbot bot added this to the Backlog milestone Jan 4, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Jan 4, 2022

This PR was merged into the repository by commit 756761d.

dylhunn pushed a commit that referenced this pull request Jan 4, 2022
@ivanwonder @dylhunn
fix(language-service): revert the test files for Ivy (#44528)
f5addee 
The `completions_spec` and `definitions_spec` is removed by accident
in [bb9ff60](bb9ff60)

PR Close #44528
@dylhunn dylhunn closed this in 756761d Jan 4, 2022
@ivanwonder ivanwonder deleted the recover-ls-test branch January 5, 2022 04:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanwonder @dylhunn @atscott