-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): remove the es6 output #4454
Conversation
We don't rely on it for anything, so we can speed up the build and simplify
lgtm, but you need to rebase it against master again. |
@alexeagle thnx for this PR, I saw that you've done some changes that I was planning to do as well (dropping traceur related transpilation). I've sent a follow-up PR #4502 to clean up some more stuff. |
@alexeagle what happened with this PR? can we get it in? :) |
I am stuck on the cyclical dependency problem. I've spent quite a bit of
On Mon, Nov 2, 2015 at 10:29 AM Igor Minar notifications@github.com wrote:
|
@alexeagle how is circular-dep check related to this PR? we currently run it on the es6 output anyway. also, have you seen #5022? |
It's related because if we remove the es6 output, we have to check for On Mon, Nov 2, 2015 at 10:34 PM Igor Minar notifications@github.com wrote:
|
Just one remark - many projects don't need to support IE or the Android Browser and such projects in a year may very well work only in ES6-capable browsers without transpilation (Edge already has almost 90% score in the kangax test so this is not a distant future). A pure ES6 build would be useful for such purposes. People can always compile Angular themselves from TypeScript to ES6 although that's harder. |
Closing as we decided to keep ES6 output for now. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We don't rely on it for anything, so we can speed up the build and simplify