New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(forms): update email validator to inherit abstractValidator #44545
refactor(forms): update email validator to inherit abstractValidator #44545
Conversation
8a10246
to
678e5c8
Compare
@dylhunn @AndrewKushnir can you help me rerun lint job, when am running in my local am not seeing in any changes let me also know if you see any other difference if you can run in your local. Help here will be appreciated, thanks. |
@iRealNirmal You should be able to run the formatting command, then push again and it will rerun automatically. Let me know if that doesn't work. |
BTW do you want a review on this? pullapprove added me and I'm not sure why. Remove draft status when you're ready :) |
FYI, this PR is blocked by #44500, which we'd need to land first. |
@dylhunn I am running in my local but unfortunately it's not showing any changes at all. |
2adc435
to
b007287
Compare
after rebase things are failing so marking back to draft mode, but still help appreciated for lint because it's still there |
f2e671d
to
08fdebf
Compare
@AndrewKushnir thanks for your input it helped to speed up task, but am still facing issue for lint at
earlier it was giving error for |
Modified email validator to inherit abstractValidator. For every validato type different PR will be raised as discussed in angular#42378. Closes angular#42267
08fdebf
to
7571264
Compare
@iRealNirmal I've pushed a fixup commit that adds a semicolon. I've also ran |
Thanks @AndrewKushnir , it's strange why running lint command in my local was not correcting it, it neither added semicolon nor brackets. Did it worked directly for you ? If yes then I will have to do something for it in my local. |
Ohh it's something tslint error and you disabled next line, thanks for taking care of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iRealNirmal the changes look good, thanks 👍
I've started tests in Google's codebase (internal-only link) and will let you know how it goes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍪
reviewed-for: public-api
@iRealNirmal FYI, some code in Google's codebase require a minor cleanup, but everything is now ready for merge. I'm adding this PR to the merge queue. Thanks again for all your efforts to unify the code of the validators! 👍 That really helps to make it more maintainable and more compact (so validators contribute less to bundle sizes). |
This PR was merged into the repository by commit c7b210d. |
…ngular#44545) Modified email validator to inherit abstractValidator. For every validato type different PR will be raised as discussed in angular#42378. Closes angular#42267 PR Close angular#44545
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Modified email validator to inherit abstractValidator.
For every validato type different PR will be raised as discussed in #42378.
Closes #42267
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #42378
What is the new behavior?
Does this PR introduce a breaking change?
Other information