Initial implementation of Standalone Components #44812

alxhub · 2022-01-25T00:03:39Z

No description provided.

atscott · 2022-01-27T18:58:00Z

packages/compiler-cli/src/ngtsc/annotations/component/src/scope.ts

-import {ComponentScopeReader} from '../../../scope';
+import {ComponentScopeReader, DtsModuleScopeResolver, ExportScope, LocalModuleScopeRegistry} from '../../../scope';
+
+import {ComponentAnalysisData} from './metadata';


 export interface ScopeTemplateResult {


Does it makes sense to have two separate interfaces at this point? ngModule is always null for standalone components and diagnostics are always empty for components declared in modules.

I think it would make things more complicated, honesty.

Having multiple interfaces is only useful if there's a benefit to be gained by distinguishing between them. For consumers of ScopeTemplateResult, there is no significant benefit to be gained from understanding, for example, that diagnostics are only present if ngModule is not. Adding the checks required to narrow the type appropriately to collect the diagnostics when present would be a net negative in terms of complexity.

atscott · 2022-01-27T21:02:40Z

packages/compiler-cli/src/ngtsc/annotations/component/src/util.ts

+        throw createValueHasWrongTypeError(
+            ref.getOriginForDiagnostics(expr), ref,
+            `'imports' must be an array of components, directives, pipes, or NgModules`);
+      }
+    } else {
+      throw createValueHasWrongTypeError(
+          expr, imports,
+          `'imports' must be an array of components, directives, pipes, or NgModules`);
+    }


These errors will mean that the language service won't give any template information for components with broken imports. Are we alright with that or should we maybe attempt to fail more gracefully and still process as much as possible? I think this is probably fine, just wanted to bring it up -- there are a number of other errors in the meta that do this as well.

I agree that we should probably move away from throwing FatalDiagnosticError. I've refactored this function to return diagnostics instead, which should allow some information to be extracted in the LS regardless of errors in imports.

atscott · 2022-01-27T22:04:15Z

packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts

+  /**
+   * Raised when a type in the `imports` of a component is a directive or pipe, but is not
+   * standalone.
+   */
+  COMPONENT_IMPORT_NOT_STANDALONE = 2011,
+
+  /**
+   * Raised when a type in the `imports` of a component is not a directive, pipe, or NgModule.
+   */
+  COMPONENT_UNKNOWN_IMPORT = 2011,


I think these two shouldn't have the same code, right?

trumbitta · 2022-02-01T09:05:22Z

"No description provided"

This is a long awaited, much dreamt-of, table-turning, etc. etc., feature. I'd love to see an extensive description of what it is and what it means for Angular, in the PR.

bampakoa · 2022-02-01T09:23:14Z

@trumbitta check out the initial RFC #43784 I hope that helps 🙂

…ages Previously each `DecoratorHandler` in the compiler was stored in a single file in the 'annotations' package. The `ComponentDecoratorHandler` in particular was several thousand lines long. Prior to implementing the new standalone functionality for components, this commit refactors 'annotations' to split these large files into their own build targets with multiple separate files. This should make the implementation of standalone significantly cleaner.

In preparation for standalone components, this commit moves the logic which determines the potential set of components/directives/pipes in a template into a separate function. This is a simple but crucial refactoring that breaks the assumption that all template scopes come from NgModules.

This commit implements the first phase of standalone components in the Angular compiler. This mainly includes the scoping rules for standalone components (`@Component({imports})`). Significant functionality from the design is _not_ implemented by this PR, including: * imports of standalone components into NgModules. * the provider aspect of standalone components Future commits will address these issues, as we proceed with the design of this feature.

atscott

reviewed-for: public-api

dylhunn

Approving for the new error codes in the .md file.

reviewed-for: public-api

jessicajaniuk

reviewed-for: public-api

AndrewKushnir

Looks great, thanks Alex! 👍

Reviewed-for: public-api

dylhunn · 2022-02-03T16:55:27Z

This PR was merged into the repository by commit 0072eb4.

#44812) In preparation for standalone components, this commit moves the logic which determines the potential set of components/directives/pipes in a template into a separate function. This is a simple but crucial refactoring that breaks the assumption that all template scopes come from NgModules. PR Close #44812

…44812) This commit implements the first phase of standalone components in the Angular compiler. This mainly includes the scoping rules for standalone components (`@Component({imports})`). Significant functionality from the design is _not_ implemented by this PR, including: * imports of standalone components into NgModules. * the provider aspect of standalone components Future commits will address these issues, as we proceed with the design of this feature. PR Close #44812

kenobi-io · 2022-02-07T08:58:43Z

packages/compiler-cli/src/ngtsc/annotations/common/src/di.ts

+  const {param, index, reason} = error;
+  let chainMessage: string|undefined = undefined;
+  let hints: ts.DiagnosticRelatedInformation[]|undefined = undefined;
+  switch (reason.kind) {


switch case is bad practics. Maybe using 'strategy' approach, for exapmle:

const kindHandlers = new Map().set(ValueUnavailableKind.UNSUPPORTED, () => {
chainMessage ='Consider using the @Inject decorator to specify an injection token.';
hints = [makeRelatedInformation( reason.typeNode, 'This type is not supported as injection token.' ), ]; }).set(...).set(...);
const handler = kindHandlers.get(reason.kind);
handler && handler.call(this, option);

angular-automatic-lock-bot · 2022-03-10T16:11:26Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…ages (angular#44812) Previously each `DecoratorHandler` in the compiler was stored in a single file in the 'annotations' package. The `ComponentDecoratorHandler` in particular was several thousand lines long. Prior to implementing the new standalone functionality for components, this commit refactors 'annotations' to split these large files into their own build targets with multiple separate files. This should make the implementation of standalone significantly cleaner. PR Close angular#44812

angular#44812) In preparation for standalone components, this commit moves the logic which determines the potential set of components/directives/pipes in a template into a separate function. This is a simple but crucial refactoring that breaks the assumption that all template scopes come from NgModules. PR Close angular#44812

…ngular#44812) This commit implements the first phase of standalone components in the Angular compiler. This mainly includes the scoping rules for standalone components (`@Component({imports})`). Significant functionality from the design is _not_ implemented by this PR, including: * imports of standalone components into NgModules. * the provider aspect of standalone components Future commits will address these issues, as we proceed with the design of this feature. PR Close angular#44812

pullapprove bot requested a review from AndrewKushnir January 25, 2022 00:03

alxhub force-pushed the ngtsc/sac/impl branch 3 times, most recently from d673adf to 171c988 Compare January 25, 2022 02:37

pullapprove bot requested review from atscott, dylhunn and jessicajaniuk January 25, 2022 02:37

alxhub force-pushed the ngtsc/sac/impl branch 3 times, most recently from 5d67801 to d6ce33c Compare January 25, 2022 22:01

jessicajaniuk added the area: core Issues related to the framework runtime label Jan 27, 2022

ngbot bot added this to the Backlog milestone Jan 27, 2022

atscott approved these changes Jan 27, 2022

View reviewed changes

pullapprove bot requested a review from atscott January 27, 2022 22:03

atscott reviewed Jan 27, 2022

View reviewed changes

pullapprove bot requested a review from atscott January 27, 2022 22:04

alxhub force-pushed the ngtsc/sac/impl branch 2 times, most recently from bba2b04 to fe776a7 Compare February 1, 2022 22:57

alxhub added 3 commits February 1, 2022 17:43

alxhub force-pushed the ngtsc/sac/impl branch from fe776a7 to 9b3d0e9 Compare February 2, 2022 01:44

alxhub added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Feb 2, 2022

atscott approved these changes Feb 3, 2022

View reviewed changes

pullapprove bot requested a review from jelbourn February 3, 2022 01:08

dylhunn approved these changes Feb 3, 2022

View reviewed changes

jessicajaniuk approved these changes Feb 3, 2022

View reviewed changes

AndrewKushnir approved these changes Feb 3, 2022

View reviewed changes

alxhub added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 3, 2022

alxhub removed the request for review from jelbourn February 3, 2022 02:04

dylhunn closed this in cc0d73d Feb 3, 2022

kenobi-io reviewed Feb 7, 2022

View reviewed changes

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial implementation of Standalone Components #44812

Initial implementation of Standalone Components #44812

alxhub commented Jan 25, 2022

atscott Jan 27, 2022

alxhub Feb 1, 2022

atscott Jan 27, 2022

alxhub Feb 1, 2022

atscott Jan 27, 2022

alxhub Feb 1, 2022

trumbitta commented Feb 1, 2022

bampakoa commented Feb 1, 2022

atscott left a comment

dylhunn left a comment

jessicajaniuk left a comment

AndrewKushnir left a comment

dylhunn commented Feb 3, 2022

kenobi-io Feb 7, 2022 •

edited

Loading

angular-automatic-lock-bot bot commented Mar 10, 2022

Initial implementation of Standalone Components #44812

Initial implementation of Standalone Components #44812

Conversation

alxhub commented Jan 25, 2022

atscott Jan 27, 2022

Choose a reason for hiding this comment

alxhub Feb 1, 2022

Choose a reason for hiding this comment

atscott Jan 27, 2022

Choose a reason for hiding this comment

alxhub Feb 1, 2022

Choose a reason for hiding this comment

atscott Jan 27, 2022

Choose a reason for hiding this comment

alxhub Feb 1, 2022

Choose a reason for hiding this comment

trumbitta commented Feb 1, 2022

bampakoa commented Feb 1, 2022

atscott left a comment

Choose a reason for hiding this comment

dylhunn left a comment

Choose a reason for hiding this comment

jessicajaniuk left a comment

Choose a reason for hiding this comment

AndrewKushnir left a comment

Choose a reason for hiding this comment

dylhunn commented Feb 3, 2022

kenobi-io Feb 7, 2022 • edited Loading

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Mar 10, 2022

kenobi-io Feb 7, 2022 •

edited

Loading