New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Explain how ngsw.json is generated. #44823
Conversation
I'd love to know if my first contribution has a green light ! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, @Arjen-1 ❤️
I made a small suggestion - otherwise lgtm 👍
Thanks @gkalpak , the suggestion looks good! |
You can preview ae49391 at https://pr44823-ae49391.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for making the update, @Arjen-1 👍
LGTM
Oh, wait! Can you please squash the commits into one? |
@gkalpak , I believe it's squashed into one commit now. Thanks for the tip! |
The for squashing, @Arjen-1. I'm afraid there are some more changes needed, though 😅
|
@gkalpak , I've done the CLA step and restored the correct commit message. Any more steps that need to be done? |
Update aio/content/guide/service-worker-devops.md ngsw.json is the manifest file which is generated at build time ( based on ngsw-config.json ). This explains this a bit clearer. At first, I thought that it was a wrongly named filename. Not is it explicitly described. Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com>
09e7059
to
d0c5449
Compare
@Arjen-1 thanks for addressing the feedback. I've noticed that the |
You can preview d0c5449 at https://pr44823-d0c5449.ngbuilds.io/. |
This PR was merged into the repository by commit 9f5edce. |
Update aio/content/guide/service-worker-devops.md ngsw.json is the manifest file which is generated at build time ( based on ngsw-config.json ). This explains this a bit clearer. At first, I thought that it was a wrongly named filename. Not is it explicitly described. Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com> PR Close #44823
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ngsw.json is the manifest file which is generated at build time ( based on ngsw-config.json ). This explains this a bit clearer.
At first, I thought that it was a wrongly named filename. Not is it explicitly described.
PR Type
Docs
What is the current behavior?
Its not explained how ngsw is created and how it differs from ngsw-config
What is the new behavior?
It explains it.
Does this PR introduce a breaking change?
Other information
Still a proces of my first contribution!